Skip to content

Commit 6699263

Browse files
committed
Compile tests with parameter names.
Disable Eclipselink stored procedure tests as they infer stored procedure variable names from the method calls. Closes #3020
1 parent a4c1d4e commit 6699263

File tree

3 files changed

+21
-33
lines changed

3 files changed

+21
-33
lines changed

pom.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -204,22 +204,6 @@
204204
</executions>
205205
</plugin>
206206

207-
<plugin>
208-
<artifactId>maven-compiler-plugin</artifactId>
209-
<executions>
210-
<execution>
211-
<id>java-test-compile</id>
212-
<phase>test-compile</phase>
213-
<goals>
214-
<goal>testCompile</goal>
215-
</goals>
216-
<configuration>
217-
<parameters>false</parameters>
218-
</configuration>
219-
</execution>
220-
</executions>
221-
</plugin>
222-
223207
</plugins>
224208
</build>
225209

spring-data-jpa/pom.xml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
</exclusion>
163163
</exclusions>
164164
</dependency>
165-
165+
166166
<dependency>
167167
<groupId>${hibernate.groupId}.orm</groupId>
168168
<artifactId>hibernate-jpamodelgen</artifactId>
@@ -379,22 +379,6 @@
379379
</configuration>
380380
</plugin>
381381

382-
<plugin>
383-
<artifactId>maven-compiler-plugin</artifactId>
384-
<executions>
385-
<execution>
386-
<id>java-test-compile</id>
387-
<phase>test-compile</phase>
388-
<goals>
389-
<goal>testCompile</goal>
390-
</goals>
391-
<configuration>
392-
<parameters>false</parameters>
393-
</configuration>
394-
</execution>
395-
</executions>
396-
</plugin>
397-
398382
<plugin>
399383
<groupId>org.codehaus.mojo</groupId>
400384
<artifactId>aspectj-maven-plugin</artifactId>

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/EclipseLinkStoredProcedureIntegrationTests.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package org.springframework.data.jpa.repository;
1717

18+
import org.junit.jupiter.api.Disabled;
19+
import org.junit.jupiter.api.Test;
1820
import org.springframework.context.annotation.ImportResource;
1921
import org.springframework.test.context.ContextConfiguration;
2022

@@ -29,4 +31,22 @@ class EclipseLinkStoredProcedureIntegrationTests extends StoredProcedureIntegrat
2931

3032
@ImportResource({ "classpath:infrastructure.xml", "classpath:eclipselink.xml" })
3133
static class TestConfig extends Config {}
34+
35+
@Override
36+
@Test
37+
@Disabled("EclipseLink parameter name inference breaks the method calls")
38+
void shouldExecuteAdHocProcedureWith1InputAnd1OutputParameter() {
39+
}
40+
41+
@Override
42+
@Test
43+
@Disabled("EclipseLink parameter name inference breaks the method calls")
44+
void shouldExecuteAdHocProcedureWith1InputAndNoOutputParameter() {
45+
}
46+
47+
@Override
48+
@Test
49+
@Disabled("EclipseLink parameter name inference breaks the method calls")
50+
void shouldExecuteAdHocProcedureWith1InputAnd1OutputParameterWithUpdate() {
51+
}
3252
}

0 commit comments

Comments
 (0)