File tree Expand file tree Collapse file tree 3 files changed +17
-3
lines changed
main/java/org/springframework/data/jpa/repository/query
test/java/org/springframework/data/jpa/repository Expand file tree Collapse file tree 3 files changed +17
-3
lines changed Original file line number Diff line number Diff line change @@ -296,9 +296,10 @@ public DeleteExecution(EntityManager em) {
296
296
297
297
Query query = jpaQuery .createQuery (accessor );
298
298
List <?> resultList = query .getResultList ();
299
+ Class <?> returnType = jpaQuery .getQueryMethod ().getReturnType ();
299
300
300
- boolean simpleBatch = Number . class . isAssignableFrom ( jpaQuery . getQueryMethod (). getReturnType () )
301
- || org .springframework .data .util .ReflectionUtils .isVoid (jpaQuery . getQueryMethod (). getReturnType () );
301
+ boolean simpleBatch = ClassUtils . isAssignable ( Number . class , returnType )
302
+ || org .springframework .data .util .ReflectionUtils .isVoid (returnType );
302
303
boolean collectionQuery = jpaQuery .getQueryMethod ().isCollectionQuery ();
303
304
304
305
if (!simpleBatch && !collectionQuery ) {
Original file line number Diff line number Diff line change @@ -1598,12 +1598,21 @@ void deleteByShouldRemoveElementsMatchingDerivedQuery() {
1598
1598
assertThat (repository .countByLastname (firstUser .getLastname ())).isZero ();
1599
1599
}
1600
1600
1601
- @ Test // DATAJPA-460
1601
+ @ Test // DATAJPA-460, GH-4015
1602
1602
void deleteByShouldReturnNumberOfEntitiesRemovedIfReturnTypeIsLong () {
1603
1603
1604
1604
flushTestUsers ();
1605
1605
1606
1606
assertThat (repository .removeByLastname (firstUser .getLastname ())).isOne ();
1607
+ assertThat (repository .removeOneByLastname (secondUser .getLastname ())).isOne ();
1608
+ }
1609
+
1610
+ @ Test // GH-4015
1611
+ void deleteByShouldReturnNumberOfEntitiesRemovedIfReturnTypeIsInt () {
1612
+
1613
+ flushTestUsers ();
1614
+
1615
+ assertThat (repository .removeOneMoreByLastname (secondUser .getLastname ())).isOne ();
1607
1616
}
1608
1617
1609
1618
@ Test // DATAJPA-460
Original file line number Diff line number Diff line change @@ -296,6 +296,10 @@ Window<User> findTop3ByFirstnameStartingWithOrderByFirstnameAscEmailAddressAsc(S
296
296
// DATAJPA-460
297
297
Long removeByLastname (String lastname );
298
298
299
+ long removeOneByLastname (String lastname );
300
+
301
+ int removeOneMoreByLastname (String lastname );
302
+
299
303
// DATAJPA-460
300
304
List <User > deleteByLastname (String lastname );
301
305
You can’t perform that action at this time.
0 commit comments