Qualify identifier used in SimpleJpaRepository.deleteAllByIdInBatch(…) JPQL
#3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ByIdInBatch with simple id. - Save 3 users and flush to allocate IDs. - Delete two using deleteAllByIdInBatch. - Assert the remaining entity is the expected one. Closes spring-projects#3990 Signed-off-by: Minho Park <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
the
has: ai-slop
mp911de
changed the title
deleteAllByIdInBatch JPQL
mp911de
added
type: bug
mp911de
changed the title
deleteAllByIdInBatch JPQLSimpleJpaRepository.deleteAllByIdInBatch(…) JPQL
|
Thank you for your contribution. That's merged, polished, and backported now. Please review properly AI-generated contributions. In this case, we have already a better place for the tests in |
mp911de
pushed a commit
that referenced
this pull request
Aug 26, 2025
……)` JPQL. Signed-off-by: Minho Park <[email protected]> Closes #3990 Original pull request: #3993
mp911de
pushed a commit
that referenced
this pull request
Aug 26, 2025
……)` JPQL. Signed-off-by: Minho Park <[email protected]> Closes #3990 Original pull request: #3993
mp911de
pushed a commit
that referenced
this pull request
Aug 26, 2025
……)` JPQL. Signed-off-by: Minho Park <[email protected]> Closes #3990 Original pull request: #3993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses GH-3990 by adding a regression test and refining the JPQL used for deleteAllByIdInBatch.
Background
EclipseLink can fail when the JPQL DELETE uses an unqualified state field in the WHERE clause. Qualifying the field with the range variable alias makes the query portable.
Changes
delete from %s x where x.%s in :idsEclipseLinkDeleteAllByIdInBatchSimpleIdTests:deleteAllByIdInBatchVerification
Built and tested locally with
./mvnw clean install(JDK 17+).Closes #3990