Replace recursion in QueryRenderer.isSubquery(…) with loop

[polyglot-k]

This pull request refactors the logic for determining whether a given ParserRuleContext represents a subquery in the JpqlQueryRenderer class. The main change is a simplification and clarification of the isSubquery method's traversal logic.

Refactoring and logic simplification:

Refactored the isSubquery method to use an explicit while loop for traversing parent contexts, making the logic easier to follow and avoiding recursive calls.

The method now returns immediately when encountering a SubqueryContext, Update_statementContext, or Delete_statementContext, and only continues traversing if none of these are found.

By replacing recursion with an iterative approach, the method avoids continuously adding frames to the call stack, improving efficiency and stack safety for deeply nested contexts.

• You have read the Spring Data contribution guidelines.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.
• You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

[mp911de]

We have similar code in EqlQueryRenderer and HqlQueryRenderer. Care to address these as well?

[polyglot-k]

@mp911de of course ! i can do that

[polyglot-k]

@mp911de
I have fixed all the places where this structure was needed.

I have one question: in the HqlQueryRenderer part, the isSetQuery method is always used as !isSetQuery. Was this maintained for the sake of consistency, or would it be more intuitive to include the negation in the method name itself?

[mp911de]

Care to use tabs for indents instead of spaces? Other than that, the pull request looks ready for merge.

[polyglot-k]

@mp911de I reflected it!

[mp911de]

I have one question: in the HqlQueryRenderer part, the isSetQuery method is always used as !isSetQuery. Was this maintained for the sake of consistency, or would it be more intuitive to include the negation in the method name itself?

That's the best name we were able to come up. isNotSetQuery is worse to read than !isSetQuery. We're always happy to get suggestions how to improve.

[polyglot-k]

I have one question: in the HqlQueryRenderer part, the isSetQuery method is always used as !isSetQuery. Was this maintained for the sake of consistency, or would it be more intuitive to include the negation in the method name itself?

That's the best name we were able to come up. isNotSetQuery is worse to read than !isSetQuery. We're always happy to get suggestions how to improve.

Yes, I understand that !
Will it merge if I leave it as it is?
@mp911de

[mp911de]

Thank you for your contribution. That's merged, polished, and backported now.

[polyglot-k]

@mp911de oh! thank u