-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Consistent handling of Specification.unrestricted()
in Specification.not(..)
#4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #4203 Signed-off-by: Peter Aisher <[email protected]>
See #4203 Signed-off-by: Peter Aisher <[email protected]>
Closes #4203 Signed-off-by: Peter Aisher <[email protected]>
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4203 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
mp911de
added a commit
that referenced
this pull request
Sep 26, 2025
Refine Javadoc. See #4203 Original pull request: #4024
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4203 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
mp911de
added a commit
that referenced
this pull request
Sep 26, 2025
Refine Javadoc. See #4203 Original pull request: #4024
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4203 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
mp911de
added a commit
that referenced
this pull request
Sep 26, 2025
Refine Javadoc. See #4203 Original pull request: #4024
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4023 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4023 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
mp911de
pushed a commit
that referenced
this pull request
Sep 26, 2025
Closes #4023 Original pull request: #4024 Signed-off-by: Peter Aisher <[email protected]>
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the handling of
Specification.unrestricted()
(and other specifications whosetoPredicate(..)
method returnsnull
) inSpecification.not(..)
to ensure consistent handling across all logical operations:Changes
not(unrestricted()).toPredicate(..)
returnsnull
and that noCriteriaBuilder
methods are called.toPredicate(..)
method returnsnull
, in particular the staticunrestricted()
factory method.Specification
,DeleteSpecification
,PredicateSpecification
, andUpdateSpecification
classes.PR Checklist
Closes #4023