Skip to content

Commit fe2c496

Browse files
author
Tomasz Forys
committed
Proper sort logging
1 parent 803f20d commit fe2c496

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,8 @@ public <T> List<T> find(Query query, Class<T> entityClass, String collectionName
865865
Assert.notNull(collectionName, "CollectionName must not be null");
866866
Assert.notNull(entityClass, "EntityClass must not be null");
867867

868-
return doFind(collectionName, createDelegate(query), query.getQueryObject(), query.getFieldsObject(), entityClass,
868+
return doFind(collectionName, createDelegate(query), query.getQueryObject(), query.getFieldsObject(),
869+
query.getSortObject(), entityClass,
869870
new QueryCursorPreparer(query, entityClass));
870871
}
871872

@@ -899,14 +900,15 @@ <T> Window<T> doScroll(Query query, Class<?> sourceClass, Class<T> targetClass,
899900
operations.getIdPropertyName(sourceClass));
900901

901902
List<T> result = doFind(collectionName, createDelegate(query), keysetPaginationQuery.query(),
902-
keysetPaginationQuery.fields(), sourceClass,
903+
keysetPaginationQuery.fields(), keysetPaginationQuery.sort(), sourceClass,
903904
new QueryCursorPreparer(query, keysetPaginationQuery.sort(), limit, 0, sourceClass), callback);
904905

905906
return ScrollUtils.createWindow(query, result, sourceClass, operations);
906907
}
907908

908909
List<T> result = doFind(collectionName, createDelegate(query), query.getQueryObject(), query.getFieldsObject(),
909-
sourceClass, new QueryCursorPreparer(query, query.getSortObject(), limit, query.getSkip(), sourceClass),
910+
query.getSortObject(), sourceClass,
911+
new QueryCursorPreparer(query, query.getSortObject(), limit, query.getSkip(), sourceClass),
910912
callback);
911913

912914
return ScrollUtils.createWindow(result, query.getLimit(), OffsetScrollPosition.positionFunction(query.getSkip()));
@@ -2559,8 +2561,8 @@ protected <T> T doFindOne(String collectionName, CollectionPreparer<MongoCollect
25592561
* @return the List of converted objects.
25602562
*/
25612563
protected <T> List<T> doFind(String collectionName, CollectionPreparer<MongoCollection<Document>> collectionPreparer,
2562-
Document query, Document fields, Class<T> entityClass) {
2563-
return doFind(collectionName, collectionPreparer, query, fields, entityClass, null,
2564+
Document query, Document fields, Document sort, Class<T> entityClass) {
2565+
return doFind(collectionName, collectionPreparer, query, fields, sort, entityClass, null,
25642566
new ReadDocumentCallback<>(this.mongoConverter, entityClass, collectionName));
25652567
}
25662568

@@ -2579,21 +2581,21 @@ protected <T> List<T> doFind(String collectionName, CollectionPreparer<MongoColl
25792581
* @return the {@link List} of converted objects.
25802582
*/
25812583
protected <T> List<T> doFind(String collectionName, CollectionPreparer<MongoCollection<Document>> collectionPreparer,
2582-
Document query, Document fields, Class<T> entityClass, CursorPreparer preparer) {
2583-
return doFind(collectionName, collectionPreparer, query, fields, entityClass, preparer,
2584+
Document query, Document fields, Document sort, Class<T> entityClass, CursorPreparer preparer) {
2585+
return doFind(collectionName, collectionPreparer, query, fields, sort, entityClass, preparer,
25842586
new ReadDocumentCallback<>(mongoConverter, entityClass, collectionName));
25852587
}
25862588

25872589
protected <S, T> List<T> doFind(String collectionName,
25882590
CollectionPreparer<MongoCollection<Document>> collectionPreparer, Document query, Document fields,
2589-
Class<S> entityClass, @Nullable CursorPreparer preparer, DocumentCallback<T> objectCallback) {
2591+
Document sort, Class<S> entityClass, @Nullable CursorPreparer preparer, DocumentCallback<T> objectCallback) {
25902592

25912593
MongoPersistentEntity<?> entity = mappingContext.getPersistentEntity(entityClass);
25922594

25932595
QueryContext queryContext = queryOperations.createQueryContext(new BasicQuery(query, fields));
25942596
Document mappedFields = queryContext.getMappedFields(entity, EntityProjection.nonProjecting(entityClass));
25952597
Document mappedQuery = queryContext.getMappedQuery(entity);
2596-
Document mappedSort = getMappedSortObject(query, entityClass);
2598+
Document mappedSort = getMappedSortObject(sort, entityClass);
25972599

25982600
if (LOGGER.isDebugEnabled()) {
25992601
LOGGER.debug(String.format("find using query: %s fields: %s sort: %s for class: %s in collection: %s",

0 commit comments

Comments
 (0)