Require explicit representation configuration for UUID, BigDecimal, and BigInteger
#5044
Conversation
Signed-off-by: Hyunsang Han <[email protected]>
Signed-off-by: Hyunsang Han <[email protected]>
HyunSangHan
changed the title
UUID, BigDecimal, and BigInteger
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
The way these changes manifest is that application startup always breaks if uuid/big decimal representations aren't configured. That isn't ideal as users that don't need these features are forced to make a configuration change.
It would be much more appropriate to check whether such types are used at all.
A utility that walks the MongoMappingContext and introspects whether entities have a property that uses UUID, BigDecimal, or BigInteger would be less invasive and more targeted. We clearly cannot capture uuid/big decimal usage that operates solely on Documents (no entity usage) and in these cases, applications would only fail during runtime.
|
|
||
| MongoClientSettings settings = builder.build(); | ||
|
|
||
| if (settings.getUuidRepresentation() == null) { |
There was a problem hiding this comment.
We would break applications for users that do not use UUIDs.
| @@ -375,6 +376,10 @@ ConverterConfiguration createConverterConfiguration() { | |||
| svc.init(); | |||
| } | |||
|
|
|||
| if (bigDecimals == null) { | |||
| throw new IllegalStateException("BigDecimal representation must be explicitly configured."); | |||
There was a problem hiding this comment.
Same breaking behavior as for UUIDs. We would also break applications for users that do not use big decimals.
| return builder.build(); | ||
| MongoClientSettings settings = builder.build(); | ||
|
|
||
| if (settings.getUuidRepresentation() == null) { |
Remove implicit defaults for UUID, BigDecimal, and BigInteger representations to force explicit configuration.
MongoConfigurationSupport: Require explicitUuidRepresentationconfiguration inmongoClientSettings()MongoClientFactoryBean: Require explicitUuidRepresentationconfiguration incomputeClientSetting()MongoCustomConversions: Require explicitBigDecimalRepresentationconfiguration (covers both BigDecimal and BigInteger)Resolves: #5037