GH-2311 - Include DiscoveryException in retry predicate.

Closes #2311.

Author: michael-simons

src/main/java/org/springframework/data/neo4j/core/support/RetryExceptionPredicate.java

@@ -22,6 +22,7 @@
 import java.util.function.Predicate;
 
 import org.apiguardian.api.API;
+import org.neo4j.driver.exceptions.DiscoveryException;
 import org.neo4j.driver.exceptions.ServiceUnavailableException;
 import org.neo4j.driver.exceptions.SessionExpiredException;
 import org.neo4j.driver.exceptions.TransientException;
@@ -60,7 +61,7 @@ public boolean test(Throwable throwable) {
 			return !("Neo.TransientError.Transaction.Terminated".equals(code) ||
 					"Neo.TransientError.Transaction.LockClientStopped".equals(code));
 		} else {
-			return ex instanceof SessionExpiredException || ex instanceof ServiceUnavailableException;
+			return ex instanceof SessionExpiredException || ex instanceof ServiceUnavailableException || ex instanceof DiscoveryException;
 		}
 	}
 }

src/test/java/org/springframework/data/neo4j/core/support/RetryExceptionPredicateTest.java

@@ -21,6 +21,7 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.junit.platform.commons.util.ReflectionUtils;
+import org.neo4j.driver.exceptions.DiscoveryException;
 import org.neo4j.driver.exceptions.ServiceUnavailableException;
 import org.neo4j.driver.exceptions.SessionExpiredException;
 import org.springframework.dao.TransientDataAccessResourceException;
@@ -48,6 +49,13 @@ void shouldNotRetryOnRandomIllegalStateExceptions() {
 		assertThat(predicate.test(new IllegalStateException())).isFalse();
 	}
 
+	@Test // GH-2311
+	void shouldRetryDiscoveryExceptions() {
+
+		RetryExceptionPredicate predicate = new RetryExceptionPredicate();
+		assertThat(predicate.test(new DiscoveryException("Broken", new RuntimeException()))).isTrue();
+	}
+
 	@Test
 	void shouldPlayWellWithExceptionTranslator() {