GH-2274 - Honor ignoreCase() from Sort.Order.

This fixes #2274.

Author: michael-simons

src/main/java/org/springframework/data/neo4j/repository/query/CypherAdapterUtils.java

@@ -21,6 +21,8 @@
 
 import org.apiguardian.api.API;
 import org.neo4j.cypherdsl.core.Cypher;
+import org.neo4j.cypherdsl.core.Expression;
+import org.neo4j.cypherdsl.core.Functions;
 import org.neo4j.cypherdsl.core.SortItem;
 import org.neo4j.cypherdsl.core.StatementBuilder;
 import org.springframework.data.domain.Pageable;
@@ -49,7 +51,11 @@ public static Function<Sort.Order, SortItem> sortAdapterFor(NodeDescription<?> n
 			String property = nodeDescription.getGraphProperty(order.getProperty())
 					.map(GraphPropertyDescription::getPropertyName).orElseThrow(() -> new IllegalStateException(
 							String.format("Cannot order by the unknown graph property: '%s'", order.getProperty())));
-			SortItem sortItem = Cypher.sort(property(Constants.NAME_OF_ROOT_NODE, property));
+			Expression expression = property(Constants.NAME_OF_ROOT_NODE, property);
+			if (order.isIgnoreCase()) {
+				expression = Functions.toLower(expression);
+			}
+			SortItem sortItem = Cypher.sort(expression);
 
 			// Spring's Sort.Order defaults to ascending, so we just need to change this if we have descending order.
 			if (order.isDescending()) {

src/test/java/org/springframework/data/neo4j/integration/imperative/RepositoryIT.java

@@ -339,6 +339,23 @@ void findAllWithSortByOrderDesc(@Autowired PersonRepository repository) {
 			assertThat(persons).containsExactly(person2, person1);
 		}
 
+		@Test // GH-2274
+		void findAllWithSortWithCaseIgnored(@Autowired PersonRepository repository) {
+
+			try (Session session = createSession()) {
+				session.writeTransaction(tx -> {
+					tx.run("CREATE (n:PersonWithAllConstructor {name: 'Ab', firstName: 'n/a'})");
+					tx.run("CREATE (n:PersonWithAllConstructor {name: 'aa', firstName: 'n/a'})");
+					return null;
+				});
+			}
+
+			List<PersonWithAllConstructor> persons = repository.findAll(Sort.by(Sort.Order.asc("name").ignoreCase()));
+			assertThat(persons)
+					.extracting(PersonWithAllConstructor::getName)
+					.containsExactly("aa", "Ab", "Test", "Test2");
+		}
+
 		@Test
 		void findAllWithPageable(@Autowired PersonRepository repository) {