DATAGRAPH-1405 - Remove superflous [At]DirtiesContext.

…and document the usage where needed.

Author: michael-simons

src/test/java/org/springframework/data/neo4j/integration/imperative/CausalClusterLoadTestIT.java

@@ -128,7 +128,7 @@ static class TestConfig extends AbstractNeo4jConfig {
 		public Driver driver() {
 
 			Driver driver = GraphDatabase.driver(neo4jUri, AuthTokens.basic("neo4j", "secret"),
-					Config.builder().withConnectionTimeout(2, TimeUnit.MINUTES).build());
+					Config.builder().withConnectionTimeout(5, TimeUnit.MINUTES).build());
 			driver.verifyConnectivity();
 			return driver;
 		}

src/test/java/org/springframework/data/neo4j/integration/imperative/RepositoryIT.java

@@ -134,7 +134,7 @@
  */
 @ExtendWith(Neo4jExtension.class)
 @SpringJUnitConfig
-@DirtiesContext
+@DirtiesContext // We need this here as the nested tests all inherit from the integration test base but the database selection here is different
 class RepositoryIT {
 
 	protected static Neo4jExtension.Neo4jConnectionSupport neo4jConnectionSupport;

src/test/java/org/springframework/data/neo4j/integration/imperative/RepositoryWithADifferentDatabaseIT.java

@@ -22,14 +22,12 @@
 import org.neo4j.driver.SessionConfig;
 import org.springframework.data.neo4j.core.DatabaseSelection;
 import org.springframework.data.neo4j.test.Neo4jExtension;
-import org.springframework.test.annotation.DirtiesContext;
 
 /**
  * @author Michael J. Simons
  */
 @Tag(Neo4jExtension.COMMERCIAL_EDITION_ONLY)
 @Tag(Neo4jExtension.REQUIRES + "4.0.0")
-@DirtiesContext
 class RepositoryWithADifferentDatabaseIT extends RepositoryIT {
 
 	private static final String TEST_DATABASE_NAME = "aTestDatabase";

src/test/java/org/springframework/data/neo4j/integration/reactive/ReactiveCausalClusterLoadTestIT.java

@@ -133,7 +133,7 @@ static class TestConfig extends AbstractReactiveNeo4jConfig {
 		public Driver driver() {
 
 			Driver driver = GraphDatabase.driver(neo4jUri, AuthTokens.basic("neo4j", "secret"),
-					Config.builder().withConnectionTimeout(2, TimeUnit.MINUTES).build());
+					Config.builder().withConnectionTimeout(5, TimeUnit.MINUTES).build());
 			driver.verifyConnectivity();
 			return driver;
 		}

src/test/java/org/springframework/data/neo4j/integration/reactive/ReactiveRepositoryIT.java

@@ -112,8 +112,8 @@
  */
 @ExtendWith(Neo4jExtension.class)
 @SpringJUnitConfig
-@DirtiesContext
 @Tag(Neo4jExtension.NEEDS_REACTIVE_SUPPORT)
+@DirtiesContext // We need this here as the nested tests all inherit from the integration test base but the database selection here is different
 class ReactiveRepositoryIT {
 
 	protected static Neo4jExtension.Neo4jConnectionSupport neo4jConnectionSupport;

src/test/java/org/springframework/data/neo4j/integration/reactive/ReactiveRepositoryWithADifferentDatabaseIT.java

@@ -22,14 +22,12 @@
 import org.neo4j.driver.SessionConfig;
 import org.springframework.data.neo4j.core.DatabaseSelection;
 import org.springframework.data.neo4j.test.Neo4jExtension;
-import org.springframework.test.annotation.DirtiesContext;
 
 /**
  * @author Michael J. Simons
  */
 @Tag(Neo4jExtension.COMMERCIAL_EDITION_ONLY)
 @Tag(Neo4jExtension.REQUIRES + "4.0.0")
-@DirtiesContext
 class ReactiveRepositoryWithADifferentDatabaseIT extends ReactiveRepositoryIT {
 
 	private static final String TEST_DATABASE_NAME = "aTestDatabase";

src/test/java/org/springframework/data/neo4j/integration/reactive/ReactiveTypeConversionIT.java

@@ -27,7 +27,6 @@
 
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.ExtendWith;
 import org.neo4j.driver.Driver;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
@@ -39,17 +38,14 @@
 import org.springframework.data.neo4j.repository.ReactiveNeo4jRepository;
 import org.springframework.data.neo4j.repository.config.EnableReactiveNeo4jRepositories;
 import org.springframework.data.neo4j.test.Neo4jExtension;
-import org.springframework.test.annotation.DirtiesContext;
-import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
+import org.springframework.data.neo4j.test.Neo4jIntegrationTest;
 import org.springframework.transaction.annotation.EnableTransactionManagement;
 
 /**
  * @author Michael J. Simons
  * @soundtrack Tom Morello - The Atlas Underground
  */
-@ExtendWith(Neo4jExtension.class)
-@SpringJUnitConfig
-@DirtiesContext
+@Neo4jIntegrationTest
 @Tag(Neo4jExtension.NEEDS_REACTIVE_SUPPORT)
 class ReactiveTypeConversionIT {