GH-2178 - Remove union creation fallback.

Author: meistermeier

src/main/java/org/springframework/data/neo4j/core/mapping/CypherGenerator.java

@@ -271,13 +271,11 @@ public Statement prepareSaveOf(NodeDescription<?> nodeDescription,
 						.where(possibleExistingNode.isNull()).create(rootNode)
 						.set(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM))).returning(rootNode.internalId()).build();
 
-				// needs a dedicated variable for the union function in the CypherDSL.
-				Node nodeToUpdate = node(primaryLabel, additionalLabels).named(Constants.NAME_OF_ROOT_NODE);
 				Statement updateIfExists = updateDecorator
-						.apply(match(nodeToUpdate).where(nodeToUpdate.property(nameOfIdProperty).isEqualTo(idParameter))
-								.and(nodeToUpdate.property(versionProperty.getName()).isEqualTo(parameter(Constants.NAME_OF_VERSION_PARAM)))
-								.mutate(nodeToUpdate, parameter(Constants.NAME_OF_PROPERTIES_PARAM)))
-						.returning(nodeToUpdate.internalId()).build();
+						.apply(match(rootNode).where(rootNode.property(nameOfIdProperty).isEqualTo(idParameter))
+								.and(rootNode.property(versionProperty.getName()).isEqualTo(parameter(Constants.NAME_OF_VERSION_PARAM)))
+								.mutate(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM)))
+						.returning(rootNode.internalId()).build();
 				return Cypher.union(createIfNew, updateIfExists);
 
 			} else {
@@ -291,9 +289,6 @@ public Statement prepareSaveOf(NodeDescription<?> nodeDescription,
 			Statement createIfNew;
 			Statement updateIfExists;
 
-			// needs a dedicated variable for the union function in the CypherDSL.
-			Node nodeToUpdate = node(primaryLabel, additionalLabels).named(Constants.NAME_OF_ROOT_NODE);
-
 			if (((Neo4jPersistentEntity) nodeDescription).hasVersionProperty()) {
 
 				PersistentProperty versionProperty = ((Neo4jPersistentEntity) nodeDescription).getRequiredVersionProperty();
@@ -304,18 +299,18 @@ public Statement prepareSaveOf(NodeDescription<?> nodeDescription,
 								.set(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM)))
 						.returning(rootNode.internalId()).build();
 
-				updateIfExists = updateDecorator.apply(match(nodeToUpdate).where(nodeToUpdate.internalId().isEqualTo(idParameter))
-						.and(nodeToUpdate.property(versionProperty.getName()).isEqualTo(parameter(Constants.NAME_OF_VERSION_PARAM)))
-						.mutate(nodeToUpdate, parameter(Constants.NAME_OF_PROPERTIES_PARAM))).returning(nodeToUpdate.internalId()).build();
+				updateIfExists = updateDecorator.apply(match(rootNode).where(rootNode.internalId().isEqualTo(idParameter))
+						.and(rootNode.property(versionProperty.getName()).isEqualTo(parameter(Constants.NAME_OF_VERSION_PARAM)))
+						.mutate(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM))).returning(rootNode.internalId()).build();
 			} else {
 				createIfNew = updateDecorator
 						.apply(optionalMatch(possibleExistingNode).where(possibleExistingNode.internalId().isEqualTo(idParameter))
 								.with(possibleExistingNode).where(possibleExistingNode.isNull()).create(rootNode)
 								.set(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM)))
 						.returning(rootNode.internalId()).build();
 
-				updateIfExists = updateDecorator.apply(match(nodeToUpdate).where(nodeToUpdate.internalId().isEqualTo(idParameter))
-						.mutate(nodeToUpdate, parameter(Constants.NAME_OF_PROPERTIES_PARAM))).returning(nodeToUpdate.internalId()).build();
+				updateIfExists = updateDecorator.apply(match(rootNode).where(rootNode.internalId().isEqualTo(idParameter))
+						.mutate(rootNode, parameter(Constants.NAME_OF_PROPERTIES_PARAM))).returning(rootNode.internalId()).build();
 			}
 
 			return Cypher.union(createIfNew, updateIfExists);