Incorporate review feedback.

Author: schauder

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java

@@ -42,6 +42,7 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
+
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.config.PropertiesFactoryBean;
 import org.springframework.context.ApplicationListener;
@@ -51,7 +52,16 @@
 import org.springframework.core.io.ClassPathResource;
 import org.springframework.dao.IncorrectResultSizeDataAccessException;
 import org.springframework.data.annotation.Id;
-import org.springframework.data.domain.*;
+import org.springframework.data.domain.Example;
+import org.springframework.data.domain.ExampleMatcher;
+import org.springframework.data.domain.Limit;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageRequest;
+import org.springframework.data.domain.Pageable;
+import org.springframework.data.domain.ScrollPosition;
+import org.springframework.data.domain.Slice;
+import org.springframework.data.domain.Sort;
+import org.springframework.data.domain.Window;
 import org.springframework.data.jdbc.core.mapping.AggregateReference;
 import org.springframework.data.jdbc.repository.query.Modifying;
 import org.springframework.data.jdbc.repository.query.Query;
@@ -913,19 +923,6 @@ void findAllByExamplePageable(Pageable pageRequest, int size, int totalPages, Li
 		}
 	}
 
-	@Test
-	void findByExampleWithCollection() {
-
-		List<Root> roots = rootRepository.saveAll(List.of(createRoot("one"), createRoot("two")));
-
-		Example<Root> example = Example
-				.of(new Root(null, "one", null, List.of(new Intermediate(null, "peter", null, null))));
-
-		Iterable<Root> result = rootRepository.findAll(example);
-
-		assertThat(result).contains(roots.get(0));
-	}
-
 	public static Stream<Arguments> findAllByExamplePageableSource() {
 		return Stream.of( //
 				Arguments.of(PageRequest.of(0, 3), 3, 34, Arrays.asList("3", "4", "100")), //
@@ -1512,7 +1509,7 @@ interface DummyEntityRepository extends CrudRepository<DummyEntity, Long>, Query
 		List<DummyEntity> findByBytes(byte[] bytes);
 	}
 
-	interface RootRepository extends ListCrudRepository<Root, Long>, QueryByExampleExecutor<Root> {
+	interface RootRepository extends ListCrudRepository<Root, Long> {
 		List<Root> findAllByOrderByIdAsc();
 	}
 

spring-data-relational/src/main/java/org/springframework/data/relational/repository/query/RelationalExampleMapper.java

@@ -38,6 +38,7 @@
  *
  * @since 2.2
  * @author Greg Turnquist
+ * @author Jens Schauder
  */
 public class RelationalExampleMapper {
 
@@ -78,7 +79,7 @@ private <T> Query getMappedExample(Example<T> example, RelationalPersistentEntit
 
 		entity.doWithProperties((PropertyHandler<RelationalPersistentProperty>) property -> {
 
-			if (property.isCollectionLike()) {
+			if (property.isCollectionLike() || property.isMap()) {
 				return;
 			}