Fix performance bug with large number of unnamed parameters

On some occasions where col in (:args) contain a really lot args, 10k+ for instance, this commit fixes a performance (high CPU) bug by NOT traversing the whole map in basically O(n^2) manner

Signed-off-by: Mikhail Fedorov <[email protected]>

Author: Fedorov, Mikhail

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/QueryMapper.java

@@ -625,20 +625,16 @@ private Expression bind(@Nullable Object mappedValue, SQLType sqlType, MapSqlPar
 	}
 
 	private static String getUniqueName(MapSqlParameterSource parameterSource, String name) {
-
-		Map<String, Object> values = parameterSource.getValues();
-
-		if (!values.containsKey(name)) {
+		Map<String, Object> parameters = parameterSource.getValues();
+		Object existingName = parameters.get(name);
+		if (existingName == null) {
 			return name;
 		}
-
-		int counter = 1;
+		int counter = parameters.size();
 		String uniqueName;
-
 		do {
 			uniqueName = name + (counter++);
-		} while (values.containsKey(uniqueName));
-
+		} while (parameters.containsKey(uniqueName));
 		return uniqueName;
 	}
 

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/QueryMapperUnitTests.java

@@ -121,7 +121,7 @@ public void shouldMapNestedGroup() {
 		Condition condition = map(criteria);
 
 		assertThat(condition).hasToString(
-				"(person.\"NAME\" = ?[:name]) AND (person.\"NAME\" = ?[:name1] OR person.age < ?[:age] OR (person.\"NAME\" != ?[:name2] AND person.age > ?[:age1]))");
+				"(person.\"NAME\" = ?[:name]) AND (person.\"NAME\" = ?[:name1] OR person.age < ?[:age] OR (person.\"NAME\" != ?[:name3] AND person.age > ?[:age4]))");
 	}
 
 	@Test // DATAJDBC-318