Recursively check embedded property loading.

Also, avoid falling back into hasValue(…) code path.

See #1676
Original pull request: #1685

Author: mp911de

spring-data-relational/src/main/java/org/springframework/data/relational/core/conversion/MappingRelationalConverter.java

@@ -552,16 +552,15 @@ private Object readEmbedded(ConversionContext conversionContext, RelationalPrope
 			RowDocumentAccessor source, RelationalPersistentProperty property,
 			RelationalPersistentEntity<?> persistentEntity) {
 
-		if (shouldReadEmbeddable(conversionContext, property, persistentEntity, provider, source)) {
+		if (shouldReadEmbeddable(conversionContext, property, persistentEntity, provider)) {
 			return read(conversionContext, persistentEntity, source);
 		}
 
 		return null;
 	}
 
 	private boolean shouldReadEmbeddable(ConversionContext context, RelationalPersistentProperty property,
-			RelationalPersistentEntity<?> unwrappedEntity, RelationalPropertyValueProvider propertyValueProvider,
-			RowDocumentAccessor source) {
+			RelationalPersistentEntity<?> unwrappedEntity, RelationalPropertyValueProvider propertyValueProvider) {
 
 		OnEmpty onEmpty = property.getRequiredAnnotation(Embedded.class).onEmpty();
 
@@ -576,16 +575,14 @@ private boolean shouldReadEmbeddable(ConversionContext context, RelationalPersis
 
 			if (persistentProperty.isEmbedded()) {
 
-				TypeInformation<?> typeInformation = persistentProperty.getTypeInformation();
+				RelationalPersistentEntity<?> nestedEntity = getMappingContext()
+						.getRequiredPersistentEntity(persistentProperty);
 
-				RelationalPersistentEntity<?> nestedEntity = getMappingContext().getPersistentEntity(typeInformation);
-
-				if (readEmbedded(nestedContext, contextual, source, persistentProperty, nestedEntity) != null) {
+				if (shouldReadEmbeddable(nestedContext, persistentProperty, nestedEntity, contextual)) {
 					return true;
 				}
-			}
 
-			if (contextual.hasValue(persistentProperty)) {
+			} else if (contextual.hasValue(persistentProperty)) {
 				return true;
 			}
 		}