remove old method

Author: schauder

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/JdbcDeleteQueryCreator.java

@@ -92,8 +92,7 @@ protected List<ParametrizedQuery> complete(@Nullable Criteria criteria, Sort sor
 		Condition condition = criteria == null ? null
 				: queryMapper.getMappedObject(parameterSource, criteria, table, entity);
 
-		List<Column> idColumns = context.getAggregatePath(entity).getTableInfo().idColumnInfos()
-				.toList(ci -> table.column(ci.name()));
+		List<Column> idColumns = context.getAggregatePath(entity).getTableInfo().idColumnInfos().toColumnList(table);
 
 		// create select criteria query for subselect
 		SelectWhere selectBuilder = StatementBuilder.select(idColumns).from(table);
@@ -138,14 +137,12 @@ private void deleteRelations(List<Delete> deleteChain, RelationalPersistentEntit
 				// MariaDB prior to 11.6 does not support aliases for delete statements
 				Table table = sqlContext.getUnaliasedTable(aggregatePath);
 
-				List<Column> reverseColumns = aggregatePath.getTableInfo().backReferenceColumnInfos()
-						.toList(ci -> table.column(ci.name()));
+				List<Column> reverseColumns = aggregatePath.getTableInfo().backReferenceColumnInfos().toColumnList(table);
 				Expression expression = Expressions.of(reverseColumns);
 
 				Condition inCondition = Conditions.in(expression, parentSelect);
 
-				List<Column> parentIdColumns = aggregatePath.getIdDefiningParentPath().getTableInfo().idColumnInfos()
-						.toList(ci -> table.column(ci.name()));
+				List<Column> parentIdColumns = aggregatePath.getIdDefiningParentPath().getTableInfo().idColumnInfos().toColumnList(table);
 
 				Select select = StatementBuilder.select( //
 						parentIdColumns //

spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/AggregatePath.java

@@ -23,7 +23,6 @@
 import java.util.function.BiConsumer;
 import java.util.function.BiFunction;
 import java.util.function.BinaryOperator;
-import java.util.function.Function;
 import java.util.function.Predicate;
 import java.util.stream.Stream;
 import java.util.stream.StreamSupport;
@@ -482,6 +481,7 @@ class ColumnInfos {
 
 		private final AggregatePath basePath;
 		private final Map<AggregatePath, ColumnInfo> columnInfos;
+		private final Map<Table, List<Column>> columnCache = new HashMap<>();
 
 		/**
 		 * Creates a new ColumnInfos instances based on the arguments.
@@ -542,18 +542,19 @@ public boolean isEmpty() {
 		}
 
 		/**
-		 * Applies a function to all the {@link ColumnInfo} instances and returns the result in a list.
+		 * Converts the given {@link Table} into a list of {@link Column}s. This method retrieves and caches the list of
+		 * columns for the specified table. If the columns are not already cached, it computes the list by mapping
+		 * {@code columnInfos} to their corresponding {@link Column} in the provided table and then stores the result in the
+		 * cache.
 		 *
-		 * @param mapper the function to be applied
-		 * @param <T> the type returned by {@literal mapper} and contained in the resulting {@literal List}
-		 * @return the list of results from mapper.
+		 * @param table the {@link Table} for which the columns should be generated; must not be {@literal null}.
+		 * @return a list of {@link Column}s associated with the specified {@link Table}. Guaranteed no to be
+		 *         {@literal null}.
 		 */
-		public <T> List<T> toList(Function<ColumnInfo, T> mapper) {
-			return columnInfos.values().stream().map(mapper).toList();
-		}
-
 		public List<Column> toColumnList(Table table) {
-			return toList(columnInfo -> table.column(columnInfo.name));
+
+			return columnCache.computeIfAbsent(table,
+					t -> columnInfos.values().stream().map(columnInfo -> t.column(columnInfo.name)).toList());
 		}
 
 		/**