Skip to content

Conversation

@mipo256
Copy link
Contributor

@mipo256 mipo256 commented Aug 17, 2025

Closes #2119

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 17, 2025
Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve in principle.

But if we move AggregateReference into relational, R2DBC should properly support it.

Also, the DCO check is failing.

@mp911de
Copy link
Member

mp911de commented Aug 18, 2025

This is a breaking change without deprecation and that doesn't work for us.

Before considering such a change, we should investigate much wider, Spring Data REST has a org.springframework.data.rest.core.AggregateReference and have a general idea how such a change fits generally into Spring Data. We should also investigate a design where AggregateReference is part of Spring Data commons with retrofitting JDBC and REST.

Note that investigate doesn't mean start implementing all the things and submitting various PR's but rather sketch a design and capture architectural decisions, constraints and effects onto today's users of the API.

@schauder
Copy link
Contributor

I'm rejecting the PR, since as Mark pointed out we need more design considerations on this one.

@schauder schauder closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate AggregateReference to the relational package

4 participants