Skip to content

Conversation

@ruturajjadhav07
Copy link
Contributor

  • [ x ] You have read the Spring Data contribution guidelines.
  • [ x ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Summary

This PR improves the Getting Started with JDBC section of the documentation by adding the missing Person entity class to the example.
Previously, the docs showed PersonRepository, MyService, and ApplicationConfig without the corresponding entity, which could confuse new users.

By including the entity definition, the example is now self-contained and easier to follow.

Example Change

@Table("person")
public class Person {

    @Id
    private Long id;
    private String firstname;
    private String lastname;

    // getters and setters
}

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2025
@ruturajjadhav07 ruturajjadhav07 force-pushed the docs/add-person-entity-example branch from e5419e1 to c1711eb Compare September 30, 2025 05:43
@schauder schauder closed this in 7349479 Oct 20, 2025
schauder added a commit that referenced this pull request Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case.

See #2146
schauder pushed a commit that referenced this pull request Oct 20, 2025
schauder added a commit that referenced this pull request Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case.

See #2146
schauder pushed a commit that referenced this pull request Oct 20, 2025
schauder added a commit that referenced this pull request Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case.

See #2146
schauder pushed a commit that referenced this pull request Oct 20, 2025
schauder added a commit that referenced this pull request Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case.

See #2146
@schauder schauder self-assigned this Oct 20, 2025
@schauder schauder self-requested a review October 20, 2025 12:25
@schauder schauder added this to the 3.4.12 (2024.1.12) milestone Oct 20, 2025
@schauder
Copy link
Contributor

This is merged.

Thanks for the contribution.

@ruturajjadhav07
Copy link
Contributor Author

This is merged.

Thanks for the contribution.

Thanks, @schauder , for reviewing and merging this PR!
Glad to see the Person entity example included in the JDBC getting started section — it should make the documentation much clearer for new users.

Appreciate the polishing and final touches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants