Polishing

Author: sbrannen

spring-core/src/main/java/org/springframework/core/io/support/PropertySourceProcessor.java

@@ -137,8 +137,8 @@ private void addPropertySource(PropertySource<?> propertySource) {
 			propertySources.addLast(propertySource);
 		}
 		else {
-			String firstProcessed = this.propertySourceNames.get(this.propertySourceNames.size() - 1);
-			propertySources.addBefore(firstProcessed, propertySource);
+			String lastAdded = this.propertySourceNames.get(this.propertySourceNames.size() - 1);
+			propertySources.addBefore(lastAdded, propertySource);
 		}
 		this.propertySourceNames.add(name);
 	}

spring-test/src/main/java/org/springframework/test/context/support/TestPropertySourceAttributes.java

@@ -126,6 +126,9 @@ private void addPropertiesAndLocationsFrom(MergedAnnotation<TestPropertySource>
 				TestContextResourceUtils.convertToClasspathResourcePaths(declaringClass, true, locations);
 		Class<? extends PropertySourceFactory> factoryClass =
 				(Class<? extends PropertySourceFactory>) mergedAnnotation.getClass("factory");
+		if (factoryClass == PropertySourceFactory.class) {
+			factoryClass = null; // default factory type will be inferred
+		}
 		String encoding = mergedAnnotation.getString("encoding");
 		if (encoding.isBlank()) {
 			encoding = null; // default encoding will be inferred

spring-test/src/main/java/org/springframework/test/context/support/TestPropertySourceUtils.java

@@ -293,8 +293,7 @@ public static void addPropertySourcesToEnvironment(ConfigurableEnvironment envir
 			for (PropertySourceDescriptor descriptor : descriptors) {
 				if (!descriptor.locations().isEmpty()) {
 					Class<? extends PropertySourceFactory> factoryClass = descriptor.propertySourceFactory();
-					PropertySourceFactory factory =
-							(factoryClass != null && factoryClass != PropertySourceFactory.class ?
+					PropertySourceFactory factory = (factoryClass != null ?
 							BeanUtils.instantiateClass(factoryClass) : defaultPropertySourceFactory);
 
 					for (String location : descriptor.locations()) {