Polishing

Author: jhoeller

spring-beans/src/test/java/org/springframework/beans/support/PropertyComparatorTests.java

@@ -53,7 +53,7 @@ public void testPropertyComparatorNulls() {
 	}
 
 	@Test
-	public void testCompoundComparator() {
+	public void testChainedComparators() {
 		Comparator<Dog> c = new PropertyComparator<>("lastName", false, true);
 
 		Dog dog1 = new Dog();
@@ -74,9 +74,10 @@ public void testCompoundComparator() {
 	}
 
 	@Test
-	public void testCompoundComparatorInvert() {
+	public void testChainedComparatorsReversed() {
 		Comparator<Dog> c = (new PropertyComparator<Dog>("lastName", false, true)).
 				thenComparing(new PropertyComparator<>("firstName", false, true));
+
 		Dog dog1 = new Dog();
 		dog1.setFirstName("macy");
 		dog1.setLastName("grayspots");
@@ -91,7 +92,6 @@ public void testCompoundComparatorInvert() {
 	}
 
 
-	@SuppressWarnings("unused")
 	private static class Dog implements Comparable<Object> {
 
 		private String nickName;

spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/OracleTableMetaDataProvider.java

@@ -117,7 +117,9 @@ public void initializeWithTableColumnMetaData(DatabaseMetaData databaseMetaData,
 			con = (Connection) con.unwrap(oracleConClass);
 		}
 		catch (ClassNotFoundException | SQLException ex) {
-			logger.warn("Unable to include synonyms in table metadata lookup - no Oracle Connection: " + ex);
+			if (logger.isWarnEnabled()) {
+				logger.warn("Unable to include synonyms in table metadata lookup - no Oracle Connection: " + ex);
+			}
 			super.initializeWithTableColumnMetaData(databaseMetaData, catalogName, schemaName, tableName);
 			return;
 		}