Polishing

Author: jhoeller

spring-expression/src/main/java/org/springframework/expression/spel/standard/SpelCompiler.java

@@ -68,7 +68,7 @@
  */
 public final class SpelCompiler implements Opcodes {
 
-	private static final int CLASSES_DEFINED_LIMIT = 10;
+	private static final int CLASSES_DEFINED_LIMIT = 100;
 
 	private static final Log logger = LogFactory.getLog(SpelCompiler.class);
 
@@ -92,7 +92,7 @@ private SpelCompiler(@Nullable ClassLoader classloader) {
 	/**
 	 * Attempt compilation of the supplied expression. A check is made to see
 	 * if it is compilable before compilation proceeds. The check involves
-	 * visiting all the nodes in the expression Ast and ensuring enough state
+	 * visiting all the nodes in the expression AST and ensuring enough state
 	 * is known about them that bytecode can be generated for them.
 	 * @param expression the expression to compile
 	 * @return an instance of the class implementing the compiled expression,
@@ -127,7 +127,7 @@ private int getNextSuffix() {
 
 	/**
 	 * Generate the class that encapsulates the compiled expression and define it.
-	 * The  generated class will be a subtype of CompiledExpression.
+	 * The generated class will be a subtype of CompiledExpression.
 	 * @param expressionToCompile the expression to be compiled
 	 * @return the expression call, or {@code null} if the decision was to opt out of
 	 * compilation during code generation
@@ -290,6 +290,9 @@ public int getClassesDefinedCount() {
 	}
 
 
+	/**
+	 * An ASM ClassWriter extension bound to the SpelCompiler's ClassLoader.
+	 */
 	private class ExpressionClassWriter extends ClassWriter {
 
 		public ExpressionClassWriter() {

spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java

@@ -614,7 +614,7 @@ void fromHttpRequestWithTrailingSlash() {
 		assertThat(after.getPath()).isEqualTo("/foo/");
 	}
 
-	@Test // gh-19890
+	@Test  // gh-19890
 	void fromHttpRequestWithEmptyScheme() {
 		HttpRequest request = new HttpRequest() {
 			@Override
@@ -896,7 +896,7 @@ void queryParamWithoutValueWithoutEquals() {
 		assertThat(uriComponents.getQueryParams().get("bar").get(0)).isNull();
 	}
 
-	@Test // gh-24444
+	@Test  // gh-24444
 	void opaqueUriDoesNotResetOnNullInput() throws URISyntaxException {
 		URI uri = new URI("urn:ietf:wg:oauth:2.0:oob");
 		UriComponents result = UriComponentsBuilder.fromUri(uri)
@@ -1156,7 +1156,7 @@ void fromHttpRequestForwardedHeaderWithProtoAndServerPort()  {
 		assertThat(result.toUriString()).isEqualTo("https://example.com/rest/mobile/users/1");
 	}
 
-	@Test // gh-25737
+	@Test  // gh-25737
 	void fromHttpRequestForwardedHeaderComma() {
 		MockHttpServletRequest request = new MockHttpServletRequest();
 		request.addHeader("Forwarded", "for=192.0.2.0,for=192.0.2.1;proto=https;host=192.0.2.3:9090");