Skip to content

Commit 1f1f222

Browse files
committed
Partial revert of 1f8913a
For WebFlux we can't use ServletContextAware. See gh-30344
1 parent 74182cd commit 1f1f222

File tree

3 files changed

+3
-47
lines changed

3 files changed

+3
-47
lines changed

spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/support/HandshakeWebSocketService.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.function.Predicate;
2626
import java.util.stream.Collectors;
2727

28-
import jakarta.servlet.ServletContext;
2928
import org.apache.commons.logging.Log;
3029
import org.apache.commons.logging.LogFactory;
3130
import reactor.core.publisher.Mono;
@@ -40,7 +39,6 @@
4039
import org.springframework.util.ClassUtils;
4140
import org.springframework.util.MultiValueMap;
4241
import org.springframework.util.StringUtils;
43-
import org.springframework.web.context.ServletContextAware;
4442
import org.springframework.web.reactive.socket.HandshakeInfo;
4543
import org.springframework.web.reactive.socket.WebSocketHandler;
4644
import org.springframework.web.reactive.socket.server.RequestUpgradeStrategy;
@@ -65,7 +63,7 @@
6563
* @author Juergen Hoeller
6664
* @since 5.0
6765
*/
68-
public class HandshakeWebSocketService implements WebSocketService, ServletContextAware, Lifecycle {
66+
public class HandshakeWebSocketService implements WebSocketService, Lifecycle {
6967

7068
private static final String SEC_WEBSOCKET_KEY = "Sec-WebSocket-Key";
7169

@@ -157,13 +155,6 @@ public Predicate<String> getSessionAttributePredicate() {
157155
return this.sessionAttributePredicate;
158156
}
159157

160-
@Override
161-
public void setServletContext(ServletContext servletContext) {
162-
if (getUpgradeStrategy() instanceof ServletContextAware servletContextAware) {
163-
servletContextAware.setServletContext(servletContext);
164-
}
165-
}
166-
167158

168159
@Override
169160
public void start() {

spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/support/WebSocketHandlerAdapter.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@
1616

1717
package org.springframework.web.reactive.socket.server.support;
1818

19-
import jakarta.servlet.ServletContext;
2019
import reactor.core.publisher.Mono;
2120

2221
import org.springframework.context.annotation.ImportRuntimeHints;
2322
import org.springframework.core.Ordered;
2423
import org.springframework.util.Assert;
25-
import org.springframework.web.context.ServletContextAware;
2624
import org.springframework.web.reactive.HandlerAdapter;
2725
import org.springframework.web.reactive.HandlerResult;
2826
import org.springframework.web.reactive.socket.WebSocketHandler;
@@ -49,7 +47,7 @@
4947
* @since 5.0
5048
*/
5149
@ImportRuntimeHints(HandshakeWebSocketServiceRuntimeHints.class)
52-
public class WebSocketHandlerAdapter implements HandlerAdapter, ServletContextAware, Ordered {
50+
public class WebSocketHandlerAdapter implements HandlerAdapter, Ordered {
5351

5452
private final WebSocketService webSocketService;
5553

@@ -99,13 +97,6 @@ public WebSocketService getWebSocketService() {
9997
return this.webSocketService;
10098
}
10199

102-
@Override
103-
public void setServletContext(ServletContext servletContext) {
104-
if (this.webSocketService instanceof ServletContextAware servletContextAware) {
105-
servletContextAware.setServletContext(servletContext);
106-
}
107-
}
108-
109100

110101
@Override
111102
public boolean supports(Object handler) {

spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/JettyRequestUpgradeStrategy.java

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@
1616

1717
package org.springframework.web.reactive.socket.server.upgrade;
1818

19-
import java.util.function.Consumer;
2019
import java.util.function.Supplier;
2120

2221
import jakarta.servlet.ServletContext;
2322
import jakarta.servlet.http.HttpServletRequest;
2423
import jakarta.servlet.http.HttpServletResponse;
2524
import org.eclipse.jetty.ee10.websocket.server.JettyWebSocketCreator;
2625
import org.eclipse.jetty.ee10.websocket.server.JettyWebSocketServerContainer;
27-
import org.eclipse.jetty.websocket.api.Configurable;
2826
import reactor.core.publisher.Mono;
2927

3028
import org.springframework.core.io.buffer.DataBufferFactory;
@@ -33,7 +31,6 @@
3331
import org.springframework.http.server.reactive.ServerHttpResponse;
3432
import org.springframework.http.server.reactive.ServerHttpResponseDecorator;
3533
import org.springframework.lang.Nullable;
36-
import org.springframework.web.context.ServletContextAware;
3734
import org.springframework.web.reactive.socket.HandshakeInfo;
3835
import org.springframework.web.reactive.socket.WebSocketHandler;
3936
import org.springframework.web.reactive.socket.adapter.ContextWebSocketHandler;
@@ -48,30 +45,7 @@
4845
* @author Rossen Stoyanchev
4946
* @since 5.3.4
5047
*/
51-
public class JettyRequestUpgradeStrategy implements RequestUpgradeStrategy, ServletContextAware {
52-
53-
@Nullable
54-
private Consumer<Configurable> webSocketConfigurer;
55-
56-
57-
/**
58-
* Add a callback to configure WebSocket server parameters on
59-
* {@link JettyWebSocketServerContainer}.
60-
* @since 6.1.0
61-
*/
62-
public void addWebSocketConfigurer(Consumer<Configurable> webSocketConfigurer) {
63-
this.webSocketConfigurer = (this.webSocketConfigurer != null ?
64-
this.webSocketConfigurer.andThen(webSocketConfigurer) : webSocketConfigurer);
65-
}
66-
67-
@Override
68-
public void setServletContext(ServletContext servletContext) {
69-
JettyWebSocketServerContainer container = JettyWebSocketServerContainer.getContainer(servletContext);
70-
if (container != null && this.webSocketConfigurer != null) {
71-
this.webSocketConfigurer.accept(container);
72-
}
73-
}
74-
48+
public class JettyRequestUpgradeStrategy implements RequestUpgradeStrategy {
7549

7650
@Override
7751
public Mono<Void> upgrade(

0 commit comments

Comments
 (0)