Skip to content

Commit 25c7e36

Browse files
committed
Polishing (including removal of javadoc imports that show as package cycles in IntelliJ)
(cherry picked from commit 2a52dec)
1 parent 9c9cc7f commit 25c7e36

File tree

6 files changed

+20
-16
lines changed

6 files changed

+20
-16
lines changed

spring-context/src/main/java/org/springframework/scheduling/config/CronTask.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2012 the original author or authors.
2+
* Copyright 2002-2013 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.scheduling.config;
1818

19-
import org.springframework.scheduling.annotation.Scheduled;
2019
import org.springframework.scheduling.support.CronTrigger;
2120

2221
/**
@@ -26,13 +25,13 @@
2625
*
2726
* @author Chris Beams
2827
* @since 3.2
29-
* @see Scheduled#cron()
28+
* @see org.springframework.scheduling.annotation.Scheduled#cron()
3029
* @see ScheduledTaskRegistrar#setCronTasksList(java.util.List)
3130
* @see org.springframework.scheduling.TaskScheduler
3231
*/
3332
public class CronTask extends TriggerTask {
3433

35-
private String expression;
34+
private final String expression;
3635

3736

3837
/**
@@ -54,7 +53,9 @@ public CronTask(Runnable runnable, CronTrigger cronTrigger) {
5453
this.expression = cronTrigger.getExpression();
5554
}
5655

56+
5757
public String getExpression() {
58-
return expression;
58+
return this.expression;
5959
}
60+
6061
}

spring-tx/src/main/java/org/springframework/transaction/config/TransactionManagementConfigUtils.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2011 the original author or authors.
2+
* Copyright 2002-2013 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,6 +16,10 @@
1616

1717
package org.springframework.transaction.config;
1818

19+
/**
20+
* @author Chris Beams
21+
* @since 3.1
22+
*/
1923
public abstract class TransactionManagementConfigUtils {
2024

2125
/**

spring-web/src/main/java/org/springframework/http/converter/support/AllEncompassingFormHttpMessageConverter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2012 the original author or authors.
2+
* Copyright 2002-2013 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -31,6 +31,9 @@
3131
*/
3232
public class AllEncompassingFormHttpMessageConverter extends FormHttpMessageConverter {
3333

34+
private static final boolean jaxb2Present =
35+
ClassUtils.isPresent("javax.xml.bind.Binder", AllEncompassingFormHttpMessageConverter.class.getClassLoader());
36+
3437
private static final boolean jackson2Present =
3538
ClassUtils.isPresent("com.fasterxml.jackson.databind.ObjectMapper", AllEncompassingFormHttpMessageConverter.class.getClassLoader()) &&
3639
ClassUtils.isPresent("com.fasterxml.jackson.core.JsonGenerator", AllEncompassingFormHttpMessageConverter.class.getClassLoader());
@@ -39,9 +42,6 @@ public class AllEncompassingFormHttpMessageConverter extends FormHttpMessageConv
3942
ClassUtils.isPresent("org.codehaus.jackson.map.ObjectMapper", AllEncompassingFormHttpMessageConverter.class.getClassLoader()) &&
4043
ClassUtils.isPresent("org.codehaus.jackson.JsonGenerator", AllEncompassingFormHttpMessageConverter.class.getClassLoader());
4144

42-
private static final boolean jaxb2Present =
43-
ClassUtils.isPresent("javax.xml.bind.Binder", AllEncompassingFormHttpMessageConverter.class.getClassLoader());
44-
4545

4646
public AllEncompassingFormHttpMessageConverter() {
4747
addPartConverter(new SourceHttpMessageConverter());

spring-web/src/main/java/org/springframework/http/converter/xml/XmlAwareFormHttpMessageConverter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2012 the original author or authors.
2+
* Copyright 2002-2013 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -17,15 +17,15 @@
1717
package org.springframework.http.converter.xml;
1818

1919
import org.springframework.http.converter.FormHttpMessageConverter;
20-
import org.springframework.http.converter.support.AllEncompassingFormHttpMessageConverter;
2120

2221
/**
2322
* Extension of {@link org.springframework.http.converter.FormHttpMessageConverter},
2423
* adding support for XML-based parts through a {@link SourceHttpMessageConverter}.
2524
*
2625
* @author Juergen Hoeller
2726
* @since 3.0.3
28-
* @deprecated in favor of {@link AllEncompassingFormHttpMessageConverter}
27+
* @deprecated in favor of
28+
* {@link org.springframework.http.converter.support.AllEncompassingFormHttpMessageConverter}
2929
*/
3030
@Deprecated
3131
public class XmlAwareFormHttpMessageConverter extends FormHttpMessageConverter {

spring-webmvc/src/main/java/org/springframework/web/servlet/support/WebContentGenerator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.springframework.web.HttpSessionRequiredException;
2929
import org.springframework.web.context.request.WebRequest;
3030
import org.springframework.web.context.support.WebApplicationObjectSupport;
31-
import org.springframework.web.servlet.mvc.LastModified;
3231

3332
/**
3433
* Convenient superclass for any kind of web content generator,
@@ -204,7 +203,7 @@ public final boolean isUseCacheControlNoStore() {
204203
* programmatically do a lastModified calculation as described in
205204
* {@link WebRequest#checkNotModified(long)}. Default is "false",
206205
* effectively relying on whether the handler implements
207-
* {@link LastModified} or not.
206+
* {@link org.springframework.web.servlet.mvc.LastModified} or not.
208207
*/
209208
public void setAlwaysMustRevalidate(boolean mustRevalidate) {
210209
this.alwaysMustRevalidate = mustRevalidate;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
http\://www.springframework.org/schema/mvc=org.springframework.web.servlet.config.MvcNamespaceHandler
1+
http\://www.springframework.org/schema/mvc=org.springframework.web.servlet.config.MvcNamespaceHandler

0 commit comments

Comments
 (0)