Fix unused assignment: the value changed at constructorArgNum++ is never used

Author: Vincent Potucek

spring-context/src/main/java/org/springframework/scripting/config/ScriptBeanDefinitionParser.java

@@ -34,6 +34,8 @@
 import org.springframework.util.StringUtils;
 import org.springframework.util.xml.DomUtils;
 
+import static org.springframework.util.StringUtils.hasLength;
+
 /**
  * BeanDefinitionParser implementation for the '{@code <lang:groovy/>}',
  * '{@code <lang:std/>}' and '{@code <lang:bsh/>}' tags.
@@ -125,7 +127,7 @@ public ScriptBeanDefinitionParser(String scriptFactoryClassName) {
 
 		// Determine bean scope.
 		String scope = element.getAttribute(SCOPE_ATTRIBUTE);
-		if (StringUtils.hasLength(scope)) {
+		if (hasLength(scope)) {
 			bd.setScope(scope);
 		}
 
@@ -143,7 +145,7 @@ else if (autowireMode == AbstractBeanDefinition.AUTOWIRE_CONSTRUCTOR) {
 
 		// Parse depends-on list of bean names.
 		String dependsOn = element.getAttribute(DEPENDS_ON_ATTRIBUTE);
-		if (StringUtils.hasLength(dependsOn)) {
+		if (hasLength(dependsOn)) {
 			bd.setDependsOn(StringUtils.tokenizeToStringArray(
 					dependsOn, BeanDefinitionParserDelegate.MULTI_VALUE_ATTRIBUTE_DELIMITERS));
 		}
@@ -153,7 +155,7 @@ else if (autowireMode == AbstractBeanDefinition.AUTOWIRE_CONSTRUCTOR) {
 
 		// Determine init method and destroy method.
 		String initMethod = element.getAttribute(INIT_METHOD_ATTRIBUTE);
-		if (StringUtils.hasLength(initMethod)) {
+		if (hasLength(initMethod)) {
 			bd.setInitMethodName(initMethod);
 		}
 		else if (beanDefinitionDefaults.getInitMethodName() != null) {
@@ -183,7 +185,7 @@ else if (beanDefinitionDefaults.getDestroyMethodName() != null) {
 		// Add constructor arguments.
 		ConstructorArgumentValues cav = bd.getConstructorArgumentValues();
 		int constructorArgNum = 0;
-		if (StringUtils.hasLength(engine)) {
+		if (hasLength(engine)) {
 			cav.addIndexedArgumentValue(constructorArgNum++, engine);
 		}
 		cav.addIndexedArgumentValue(constructorArgNum++, value);
@@ -194,12 +196,11 @@ else if (beanDefinitionDefaults.getDestroyMethodName() != null) {
 
 		// This is used for Groovy. It's a bean reference to a customizer bean.
 		if (element.hasAttribute(CUSTOMIZER_REF_ATTRIBUTE)) {
-			String customizerBeanName = element.getAttribute(CUSTOMIZER_REF_ATTRIBUTE);
-			if (!StringUtils.hasText(customizerBeanName)) {
+			if (!StringUtils.hasText(element.getAttribute(CUSTOMIZER_REF_ATTRIBUTE))) {
 				parserContext.getReaderContext().error("Attribute 'customizer-ref' has empty value", element);
 			}
 			else {
-				cav.addIndexedArgumentValue(constructorArgNum++, new RuntimeBeanReference(customizerBeanName));
+				cav.addIndexedArgumentValue(constructorArgNum , new RuntimeBeanReference(element.getAttribute(CUSTOMIZER_REF_ATTRIBUTE)));
 			}
 		}