PropertySource implementations perform conversion to String arrays via StringUtils (getting rid of EMPTY_NAMES_ARRAY)

(cherry picked from commit b73c531)

Author: jhoeller

spring-core/src/main/java/org/springframework/core/env/EnumerablePropertySource.java

@@ -45,6 +45,7 @@
  */
 public abstract class EnumerablePropertySource<T> extends PropertySource<T> {
 
+	@Deprecated
 	protected static final String[] EMPTY_NAMES_ARRAY = new String[0];
 
 	protected final Log logger = LogFactory.getLog(getClass());

spring-core/src/main/java/org/springframework/core/env/MapPropertySource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2011 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,6 +18,8 @@
 
 import java.util.Map;
 
+import org.springframework.util.StringUtils;
+
 /**
  * {@link PropertySource} that reads keys and values from a {@code Map} object.
  *
@@ -38,7 +40,7 @@ public Object getProperty(String name) {
 
 	@Override
 	public String[] getPropertyNames() {
-		return this.source.keySet().toArray(EMPTY_NAMES_ARRAY);
+		return StringUtils.toStringArray(this.source.keySet());
 	}
 
 }

spring-core/src/main/java/org/springframework/core/env/MutablePropertySources.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.util.Assert;
 import org.springframework.util.StringUtils;
 
@@ -66,7 +67,7 @@ public MutablePropertySources(PropertySources propertySources) {
 	}
 
 	/**
-	 * Create a new {@link MutablePropertySources} object and inheriting the given logger,
+	 * Create a new {@link MutablePropertySources} object and inherit the given logger,
 	 * usually from an enclosing {@link Environment}.
 	 */
 	MutablePropertySources(Log logger) {
@@ -130,7 +131,7 @@ public void addBefore(String relativePropertySourceName, PropertySource<?> prope
 	}
 
 	/**
-	 * Add the given property source object with precedence immediately lower than
+	 * Add the given property source object with precedence immediately lower
 	 * than the named relative property source.
 	 */
 	public void addAfter(String relativePropertySourceName, PropertySource<?> propertySource) {
@@ -187,7 +188,7 @@ public int size() {
 	}
 
 	@Override
-	public synchronized String toString() {
+	public String toString() {
 		String[] names = new String[this.size()];
 		for (int i=0; i < size(); i++) {
 			names[i] = this.propertySourceList.get(i).getName();
@@ -205,7 +206,7 @@ protected void assertLegalRelativeAddition(String relativePropertySourceName, Pr
 	}
 
 	/**
-	 * Log the removal of the given propertySource if it is present.
+	 * Remove the given property source if it is present.
 	 */
 	protected void removeIfPresent(PropertySource<?> propertySource) {
 		if (this.propertySourceList.contains(propertySource)) {

spring-web/src/main/java/org/springframework/web/context/support/ServletConfigPropertySource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2011 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
 
 import org.springframework.core.env.EnumerablePropertySource;
 import org.springframework.core.env.PropertySource;
-import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
 
 /**
  * {@link PropertySource} that reads init parameters from a {@link ServletConfig} object.
@@ -37,8 +37,7 @@ public ServletConfigPropertySource(String name, ServletConfig servletConfig) {
 
 	@Override
 	public String[] getPropertyNames() {
-		return CollectionUtils.toArray(
-				this.source.getInitParameterNames(), EMPTY_NAMES_ARRAY);
+		return StringUtils.toStringArray(this.source.getInitParameterNames());
 	}
 
 	@Override

spring-web/src/main/java/org/springframework/web/context/support/ServletContextPropertySource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
 
 import org.springframework.core.env.EnumerablePropertySource;
 import org.springframework.core.env.PropertySource;
-import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
 
 /**
  * {@link PropertySource} that reads init parameters from a {@link ServletContext} object.
@@ -37,12 +37,12 @@ public ServletContextPropertySource(String name, ServletContext servletContext)
 
 	@Override
 	public String[] getPropertyNames() {
-		return CollectionUtils.toArray(
-				this.source.getInitParameterNames(), EMPTY_NAMES_ARRAY);
+		return StringUtils.toStringArray(this.source.getInitParameterNames());
 	}
 
 	@Override
 	public String getProperty(String name) {
 		return this.source.getInitParameter(name);
 	}
+
 }

spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/context/PortletConfigPropertySource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2011 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
 
 import org.springframework.core.env.EnumerablePropertySource;
 import org.springframework.core.env.PropertySource;
-import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
 
 /**
  * {@link PropertySource} that reads init parameters from a {@link PortletConfig} object.
@@ -37,11 +37,12 @@ public PortletConfigPropertySource(String name, PortletConfig portletConfig) {
 
 	@Override
 	public String[] getPropertyNames() {
-		return CollectionUtils.toArray(this.source.getInitParameterNames(), EMPTY_NAMES_ARRAY);
+		return StringUtils.toStringArray(this.source.getInitParameterNames());
 	}
 
 	@Override
 	public String getProperty(String name) {
 		return this.source.getInitParameter(name);
 	}
+
 }

spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/context/PortletContextPropertySource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2011 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
 
 import org.springframework.core.env.EnumerablePropertySource;
 import org.springframework.core.env.PropertySource;
-import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
 
 /**
  * {@link PropertySource} that reads init parameters from a {@link PortletContext} object.
@@ -37,11 +37,12 @@ public PortletContextPropertySource(String name, PortletContext portletContext)
 
 	@Override
 	public String[] getPropertyNames() {
-		return CollectionUtils.toArray(this.source.getInitParameterNames(), EMPTY_NAMES_ARRAY);
+		return StringUtils.toStringArray(this.source.getInitParameterNames());
 	}
 
 	@Override
 	public String getProperty(String name) {
 		return this.source.getInitParameter(name);
 	}
+
 }