Skip to content

Commit 3ac14e7

Browse files
committed
Document websocket XML namespace
Issue: SPR-11063
1 parent 14468e8 commit 3ac14e7

File tree

3 files changed

+333
-36
lines changed

3 files changed

+333
-36
lines changed

spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ private RuntimeBeanReference registerHttpRequestHandler(Element stompEndpointEle
264264
cavs.addIndexedArgumentValue(1, handshakeHandler);
265265
}
266266
httpRequestHandlerDef = new RootBeanDefinition(WebSocketHttpRequestHandler.class, cavs, null);
267-
// TODO: httpRequestHandlerDef.getPropertyValues().add("handshakeInterceptors", ...);
268267
}
269268

270269
String httpRequestHandlerBeanName = registerBeanDef(httpRequestHandlerDef, parserCxt, source);

spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketNamespaceUtils.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ public static RuntimeBeanReference registerSockJsService(Element element, String
6565
if (sockJsElement != null) {
6666
ConstructorArgumentValues cavs = new ConstructorArgumentValues();
6767

68-
// TODO: polish the way constructor arguments are set
69-
7068
String customTaskSchedulerName = sockJsElement.getAttribute("scheduler");
7169
if (!customTaskSchedulerName.isEmpty()) {
7270
cavs.addIndexedArgumentValue(0, new RuntimeBeanReference(customTaskSchedulerName));

0 commit comments

Comments
 (0)