Polish

Author: rstoyanchev

spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandler.java

@@ -188,11 +188,11 @@ protected String[] getTargetDestinations(Annotation annotation, Message<?> messa
 			}
 		}
 		String name = DestinationPatternsMessageCondition.LOOKUP_DESTINATION_HEADER;
-		String destination = (String)message.getHeaders().get(name);
-		if (StringUtils.hasLength(destination) && !destination.startsWith("/")) {
-			destination = "/" + destination;
-		}
-		return new String[] { defaultPrefix + destination };
+		String destination = (String) message.getHeaders().get(name);
+		Assert.hasText(destination, "No lookup destination header in " + message);
+
+		return (destination.startsWith("/") ?
+				new String[] {defaultPrefix + destination} : new String[] {defaultPrefix + "/" + destination});
 	}
 
 	private MessageHeaders createHeaders(String sessionId) {

spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandlerTests.java

@@ -186,18 +186,18 @@ public void sendToDefaultDestination() throws Exception {
 	}
 
 	@Test
-	public void sendToDefaultDestinationWithoutLeadingSlash() throws Exception {
+	public void sendToDefaultDestinationWhenUsingDotPathSeparator() throws Exception {
 
 		when(this.messageChannel.send(any(Message.class))).thenReturn(true);
 
-		Message<?> inputMessage = createInputMessage("sess1", "sub1", "/app", "dest", null);
+		Message<?> inputMessage = createInputMessage("sess1", "sub1", "/app/", "dest.foo.bar", null);
 		this.handler.handleReturnValue(PAYLOAD, this.sendToDefaultDestReturnType, inputMessage);
 
 		verify(this.messageChannel, times(1)).send(this.messageCaptor.capture());
 
 		Message<?> message = this.messageCaptor.getAllValues().get(0);
 		SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message);
-		assertEquals("/topic/dest", headers.getDestination());
+		assertEquals("/topic/dest.foo.bar", headers.getDestination());
 	}
 
 	@Test
@@ -313,19 +313,19 @@ public void sendToUserDefaultDestination() throws Exception {
 	}
 
 	@Test
-	public void sendToUserDefaultDestinationWithoutLeadingSlash() throws Exception {
+	public void sendToUserDefaultDestinationWhenUsingDotPathSeparator() throws Exception {
 
 		when(this.messageChannel.send(any(Message.class))).thenReturn(true);
 
 		TestUser user = new TestUser();
-		Message<?> inputMessage = createInputMessage("sess1", "sub1", "/app", "dest", user);
+		Message<?> inputMessage = createInputMessage("sess1", "sub1", "/app/", "dest.foo.bar", user);
 		this.handler.handleReturnValue(PAYLOAD, this.sendToUserDefaultDestReturnType, inputMessage);
 
 		verify(this.messageChannel, times(1)).send(this.messageCaptor.capture());
 
 		Message<?> message = this.messageCaptor.getAllValues().get(0);
 		SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message);
-		assertEquals("/user/" + user.getName() + "/queue/dest", headers.getDestination());
+		assertEquals("/user/" + user.getName() + "/queue/dest.foo.bar", headers.getDestination());
 	}
 
 	@Test