Skip to content

Commit 4642c32

Browse files
committed
Defensively expect concurrent registration of BeanPostProcessors
Declaring beanPostProcessors (and also embeddedValueResolvers) as CopyOnWriteArrayList prevents ConcurrentModificationExceptions in case of concurrent registration/access attempts. Issue: SPR-17286
1 parent a55261f commit 4642c32

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
import java.util.HashSet;
3030
import java.util.LinkedHashMap;
3131
import java.util.LinkedHashSet;
32-
import java.util.LinkedList;
3332
import java.util.List;
3433
import java.util.Map;
3534
import java.util.Set;
3635
import java.util.concurrent.ConcurrentHashMap;
36+
import java.util.concurrent.CopyOnWriteArrayList;
3737

3838
import org.springframework.beans.BeanUtils;
3939
import org.springframework.beans.BeanWrapper;
@@ -145,16 +145,16 @@ public abstract class AbstractBeanFactory extends FactoryBeanRegistrySupport imp
145145
private TypeConverter typeConverter;
146146

147147
/** String resolvers to apply e.g. to annotation attribute values */
148-
private final List<StringValueResolver> embeddedValueResolvers = new LinkedList<>();
148+
private final List<StringValueResolver> embeddedValueResolvers = new CopyOnWriteArrayList<>();
149149

150150
/** BeanPostProcessors to apply in createBean */
151-
private final List<BeanPostProcessor> beanPostProcessors = new ArrayList<>();
151+
private final List<BeanPostProcessor> beanPostProcessors = new CopyOnWriteArrayList<>();
152152

153153
/** Indicates whether any InstantiationAwareBeanPostProcessors have been registered */
154-
private boolean hasInstantiationAwareBeanPostProcessors;
154+
private volatile boolean hasInstantiationAwareBeanPostProcessors;
155155

156156
/** Indicates whether any DestructionAwareBeanPostProcessors have been registered */
157-
private boolean hasDestructionAwareBeanPostProcessors;
157+
private volatile boolean hasDestructionAwareBeanPostProcessors;
158158

159159
/** Map from scope identifier String to corresponding Scope */
160160
private final Map<String, Scope> scopes = new LinkedHashMap<>(8);
@@ -847,14 +847,17 @@ public String resolveEmbeddedValue(@Nullable String value) {
847847
@Override
848848
public void addBeanPostProcessor(BeanPostProcessor beanPostProcessor) {
849849
Assert.notNull(beanPostProcessor, "BeanPostProcessor must not be null");
850+
// Remove from old position, if any
850851
this.beanPostProcessors.remove(beanPostProcessor);
851-
this.beanPostProcessors.add(beanPostProcessor);
852+
// Track whether it is instantiation/destruction aware
852853
if (beanPostProcessor instanceof InstantiationAwareBeanPostProcessor) {
853854
this.hasInstantiationAwareBeanPostProcessors = true;
854855
}
855856
if (beanPostProcessor instanceof DestructionAwareBeanPostProcessor) {
856857
this.hasDestructionAwareBeanPostProcessors = true;
857858
}
859+
// Add to end of list
860+
this.beanPostProcessors.add(beanPostProcessor);
858861
}
859862

860863
@Override
@@ -985,7 +988,6 @@ public void copyConfigurationFrom(ConfigurableBeanFactory otherFactory) {
985988
@Override
986989
public BeanDefinition getMergedBeanDefinition(String name) throws BeansException {
987990
String beanName = transformedBeanName(name);
988-
989991
// Efficiently check whether bean definition exists in this factory.
990992
if (!containsBeanDefinition(beanName) && getParentBeanFactory() instanceof ConfigurableBeanFactory) {
991993
return ((ConfigurableBeanFactory) getParentBeanFactory()).getMergedBeanDefinition(beanName);
@@ -997,18 +999,15 @@ public BeanDefinition getMergedBeanDefinition(String name) throws BeansException
997999
@Override
9981000
public boolean isFactoryBean(String name) throws NoSuchBeanDefinitionException {
9991001
String beanName = transformedBeanName(name);
1000-
10011002
Object beanInstance = getSingleton(beanName, false);
10021003
if (beanInstance != null) {
10031004
return (beanInstance instanceof FactoryBean);
10041005
}
1005-
10061006
// No singleton instance found -> check bean definition.
10071007
if (!containsBeanDefinition(beanName) && getParentBeanFactory() instanceof ConfigurableBeanFactory) {
10081008
// No bean definition found in this factory -> delegate to parent.
10091009
return ((ConfigurableBeanFactory) getParentBeanFactory()).isFactoryBean(name);
10101010
}
1011-
10121011
return isFactoryBean(beanName, getMergedLocalBeanDefinition(beanName));
10131012
}
10141013

0 commit comments

Comments
 (0)