Skip to content

Commit 4d1d60a

Browse files
committed
Check log level before delegating Supplier-based message to target Log
Closes gh-25741
1 parent c6cc670 commit 4d1d60a

File tree

1 file changed

+37
-13
lines changed

1 file changed

+37
-13
lines changed

spring-core/src/main/java/org/springframework/core/log/LogAccessor.java

Lines changed: 37 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2019 the original author or authors.
2+
* Copyright 2002-2020 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -225,7 +225,9 @@ public void trace(Throwable cause, CharSequence message) {
225225
* @param messageSupplier a lazy supplier for the message to log
226226
*/
227227
public void fatal(Supplier<? extends CharSequence> messageSupplier) {
228-
this.log.fatal(LogMessage.of(messageSupplier));
228+
if (this.log.isFatalEnabled()) {
229+
this.log.fatal(LogMessage.of(messageSupplier));
230+
}
229231
}
230232

231233
/**
@@ -234,15 +236,19 @@ public void fatal(Supplier<? extends CharSequence> messageSupplier) {
234236
* @param messageSupplier a lazy supplier for the message to log
235237
*/
236238
public void fatal(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
237-
this.log.fatal(LogMessage.of(messageSupplier), cause);
239+
if (this.log.isFatalEnabled()) {
240+
this.log.fatal(LogMessage.of(messageSupplier), cause);
241+
}
238242
}
239243

240244
/**
241245
* Log a message with error log level.
242246
* @param messageSupplier a lazy supplier for the message to log
243247
*/
244248
public void error(Supplier<? extends CharSequence> messageSupplier) {
245-
this.log.error(LogMessage.of(messageSupplier));
249+
if (this.log.isErrorEnabled()) {
250+
this.log.error(LogMessage.of(messageSupplier));
251+
}
246252
}
247253

248254
/**
@@ -251,15 +257,19 @@ public void error(Supplier<? extends CharSequence> messageSupplier) {
251257
* @param messageSupplier a lazy supplier for the message to log
252258
*/
253259
public void error(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
254-
this.log.error(LogMessage.of(messageSupplier), cause);
260+
if (this.log.isErrorEnabled()) {
261+
this.log.error(LogMessage.of(messageSupplier), cause);
262+
}
255263
}
256264

257265
/**
258266
* Log a message with warn log level.
259267
* @param messageSupplier a lazy supplier for the message to log
260268
*/
261269
public void warn(Supplier<? extends CharSequence> messageSupplier) {
262-
this.log.warn(LogMessage.of(messageSupplier));
270+
if (this.log.isWarnEnabled()) {
271+
this.log.warn(LogMessage.of(messageSupplier));
272+
}
263273
}
264274

265275
/**
@@ -268,15 +278,19 @@ public void warn(Supplier<? extends CharSequence> messageSupplier) {
268278
* @param messageSupplier a lazy supplier for the message to log
269279
*/
270280
public void warn(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
271-
this.log.warn(LogMessage.of(messageSupplier), cause);
281+
if (this.log.isWarnEnabled()) {
282+
this.log.warn(LogMessage.of(messageSupplier), cause);
283+
}
272284
}
273285

274286
/**
275287
* Log a message with info log level.
276288
* @param messageSupplier a lazy supplier for the message to log
277289
*/
278290
public void info(Supplier<? extends CharSequence> messageSupplier) {
279-
this.log.info(LogMessage.of(messageSupplier));
291+
if (this.log.isInfoEnabled()) {
292+
this.log.info(LogMessage.of(messageSupplier));
293+
}
280294
}
281295

282296
/**
@@ -285,15 +299,19 @@ public void info(Supplier<? extends CharSequence> messageSupplier) {
285299
* @param messageSupplier a lazy supplier for the message to log
286300
*/
287301
public void info(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
288-
this.log.info(LogMessage.of(messageSupplier), cause);
302+
if (this.log.isInfoEnabled()) {
303+
this.log.info(LogMessage.of(messageSupplier), cause);
304+
}
289305
}
290306

291307
/**
292308
* Log a message with debug log level.
293309
* @param messageSupplier a lazy supplier for the message to log
294310
*/
295311
public void debug(Supplier<? extends CharSequence> messageSupplier) {
296-
this.log.debug(LogMessage.of(messageSupplier));
312+
if (this.log.isDebugEnabled()) {
313+
this.log.debug(LogMessage.of(messageSupplier));
314+
}
297315
}
298316

299317
/**
@@ -302,15 +320,19 @@ public void debug(Supplier<? extends CharSequence> messageSupplier) {
302320
* @param messageSupplier a lazy supplier for the message to log
303321
*/
304322
public void debug(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
305-
this.log.debug(LogMessage.of(messageSupplier), cause);
323+
if (this.log.isDebugEnabled()) {
324+
this.log.debug(LogMessage.of(messageSupplier), cause);
325+
}
306326
}
307327

308328
/**
309329
* Log a message with trace log level.
310330
* @param messageSupplier a lazy supplier for the message to log
311331
*/
312332
public void trace(Supplier<? extends CharSequence> messageSupplier) {
313-
this.log.trace(LogMessage.of(messageSupplier));
333+
if (this.log.isTraceEnabled()) {
334+
this.log.trace(LogMessage.of(messageSupplier));
335+
}
314336
}
315337

316338
/**
@@ -319,7 +341,9 @@ public void trace(Supplier<? extends CharSequence> messageSupplier) {
319341
* @param messageSupplier a lazy supplier for the message to log
320342
*/
321343
public void trace(Throwable cause, Supplier<? extends CharSequence> messageSupplier) {
322-
this.log.trace(LogMessage.of(messageSupplier), cause);
344+
if (this.log.isTraceEnabled()) {
345+
this.log.trace(LogMessage.of(messageSupplier), cause);
346+
}
323347
}
324348

325349
}

0 commit comments

Comments
 (0)