Skip to content

Commit 515bae9

Browse files
committed
Defensively access existing beanDefinitionMap entries
See gh-22263 (cherry picked from commit f1345aa)
1 parent 7a79358 commit 515bae9

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -641,8 +641,8 @@ public <T> Map<String, T> getBeansOfType(
641641
public String[] getBeanNamesForAnnotation(Class<? extends Annotation> annotationType) {
642642
List<String> result = new ArrayList<>();
643643
for (String beanName : this.beanDefinitionNames) {
644-
BeanDefinition beanDefinition = this.beanDefinitionMap.get(beanName);
645-
if (!beanDefinition.isAbstract() && findAnnotationOnBean(beanName, annotationType) != null) {
644+
BeanDefinition bd = this.beanDefinitionMap.get(beanName);
645+
if (bd != null && !bd.isAbstract() && findAnnotationOnBean(beanName, annotationType) != null) {
646646
result.add(beanName);
647647
}
648648
}
@@ -1023,8 +1023,7 @@ protected void resetBeanDefinition(String beanName) {
10231023
for (String bdName : this.beanDefinitionNames) {
10241024
if (!beanName.equals(bdName)) {
10251025
BeanDefinition bd = this.beanDefinitionMap.get(bdName);
1026-
// Ensure bd is non-null due to potential concurrent modification
1027-
// of the beanDefinitionMap.
1026+
// Ensure bd is non-null due to potential concurrent modification of beanDefinitionMap.
10281027
if (bd != null && beanName.equals(bd.getParentName())) {
10291028
resetBeanDefinition(bdName);
10301029
}

0 commit comments

Comments
 (0)