improve the performance of iteration

diguage · jhoeller · commit 564c6f7f8646 · 2021-07-09T15:10:18.000+02:00
diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionReader.java b/spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionReader.java
@@ -489,9 +489,9 @@ else if (args[0] instanceof Map) {
 						resolveConstructorArguments(args, 2, hasClosureArgument ? args.length - 1 : args.length);
 				this.currentBeanDefinition = new GroovyBeanDefinitionWrapper(beanName, (Class<?>) args[1], constructorArgs);
 				Map<?, ?> namedArgs = (Map<?, ?>) args[0];
-				for (Object key : namedArgs.keySet()) {
-					String propName = (String) key;
-					setProperty(propName, namedArgs.get(propName));
+				for (Map.Entry<?, ?> entity : namedArgs.entrySet()) {
+					String propName = (String) entity.getKey();
+					setProperty(propName, entity.getValue());
 				}
 			}
 			// factory method syntax

Original file line number	Diff line number	Diff line change
`@@ -489,9 +489,9 @@ else if (args[0] instanceof Map) {`
`489`	`489`	`resolveConstructorArguments(args, 2, hasClosureArgument ? args.length - 1 : args.length);`
`490`	`490`	`this.currentBeanDefinition = new GroovyBeanDefinitionWrapper(beanName, (Class<?>) args[1], constructorArgs);`
`491`	`491`	`Map<?, ?> namedArgs = (Map<?, ?>) args[0];`
`492`		`- for (Object key : namedArgs.keySet()) {`
`493`		`- String propName = (String) key;`
`494`		`- setProperty(propName, namedArgs.get(propName));`
	`492`	`+ for (Map.Entry<?, ?> entity : namedArgs.entrySet()) {`
	`493`	`+ String propName = (String) entity.getKey();`
	`494`	`+ setProperty(propName, entity.getValue());`
`495`	`495`	`}`
`496`	`496`	`}`
`497`	`497`	`// factory method syntax`