Skip to content

Commit 63a1348

Browse files
committed
Polish LoggingResultHandler in Spring MVC Test
Issue: SPR-13171
1 parent 693dcba commit 63a1348

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

spring-test/src/main/java/org/springframework/test/web/servlet/result/MockMvcResultHandlers.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,16 +123,15 @@ public void printValue(String label, Object value) {
123123
*/
124124
private static class LoggingResultHandler implements ResultHandler {
125125

126-
private final StringWriter stringWriter = new StringWriter();
127-
128-
private final ResultHandler printingResultHandler = new PrintWriterPrintingResultHandler(
129-
new PrintWriter(stringWriter, true));
130-
131-
132126
@Override
133127
public void handle(MvcResult result) throws Exception {
134-
this.printingResultHandler.handle(result);
135-
logger.debug("MvcResult details:\n" + this.stringWriter);
128+
if (logger.isDebugEnabled()) {
129+
StringWriter stringWriter = new StringWriter();
130+
ResultHandler printingResultHandler = new PrintWriterPrintingResultHandler(
131+
new PrintWriter(stringWriter));
132+
printingResultHandler.handle(result);
133+
logger.debug("MvcResult details:\n" + stringWriter);
134+
}
136135
}
137136
}
138137

0 commit comments

Comments
 (0)