Avoid potential integer overflow in seconds->millis transformation

jhoeller · jhoeller · commit 6c977e9c2a4d · 2020-08-27T15:59:52.000+02:00
Closes gh-25613
diff --git a/spring-context/src/main/java/org/springframework/context/support/AbstractResourceBasedMessageSource.java b/spring-context/src/main/java/org/springframework/context/support/AbstractResourceBasedMessageSource.java
@@ -173,7 +173,7 @@ protected boolean isFallbackToSystemLocale() {
 	 * a non-classpath location.
 	 */
 	public void setCacheSeconds(int cacheSeconds) {
-		this.cacheMillis = (cacheSeconds * 1000);
+		this.cacheMillis = cacheSeconds * 1000L;
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ protected boolean isFallbackToSystemLocale() {`
`173`	`173`	`* a non-classpath location.`
`174`	`174`	`*/`
`175`	`175`	`public void setCacheSeconds(int cacheSeconds) {`
`176`		`- this.cacheMillis = (cacheSeconds * 1000);`
	`176`	`+ this.cacheMillis = cacheSeconds * 1000L;`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`/**`