Skip to content

Commit 7a20ed7

Browse files
committed
fixed timeout assertion
1 parent 9958895 commit 7a20ed7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

org.springframework.web/src/main/java/org/springframework/http/client/CommonsClientHttpRequestFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public HttpClient getHttpClient() {
9494
* @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setConnectionTimeout(int)
9595
*/
9696
public void setConnectTimeout(int timeout) {
97-
Assert.isTrue(timeout < 0, "Timeout must be a non-negative value");
97+
Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value");
9898
this.httpClient.getHttpConnectionManager().getParams().setConnectionTimeout(timeout);
9999
}
100100

@@ -105,7 +105,7 @@ public void setConnectTimeout(int timeout) {
105105
* @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setSoTimeout(int)
106106
*/
107107
public void setReadTimeout(int timeout) {
108-
Assert.isTrue(timeout < 0, "Timeout must be a non-negative value");
108+
Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value");
109109
getHttpClient().getHttpConnectionManager().getParams().setSoTimeout(timeout);
110110
}
111111

org.springframework.web/src/main/java/org/springframework/remoting/httpinvoker/CommonsHttpInvokerRequestExecutor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public HttpClient getHttpClient() {
102102
* @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setConnectionTimeout(int)
103103
*/
104104
public void setConnectTimeout(int timeout) {
105-
Assert.isTrue(timeout < 0, "Timeout must be a non-negative value");
105+
Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value");
106106
this.httpClient.getHttpConnectionManager().getParams().setConnectionTimeout(timeout);
107107
}
108108

@@ -114,7 +114,7 @@ public void setConnectTimeout(int timeout) {
114114
* @see #DEFAULT_READ_TIMEOUT_MILLISECONDS
115115
*/
116116
public void setReadTimeout(int timeout) {
117-
Assert.isTrue(timeout < 0, "Timeout must be a non-negative value");
117+
Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value");
118118
this.httpClient.getHttpConnectionManager().getParams().setSoTimeout(timeout);
119119
}
120120

0 commit comments

Comments
 (0)