Skip to content

Commit 7b94a05

Browse files
committed
Rename AbstractMockServerSpec and friends
Fixes gh-31275 Signed-off-by: Rob Worsnop <[email protected]>
1 parent 590a162 commit 7b94a05

File tree

6 files changed

+39
-39
lines changed

6 files changed

+39
-39
lines changed

spring-test/src/main/java/org/springframework/test/web/server/AbstractMockMvcServerSpec.java renamed to spring-test/src/main/java/org/springframework/test/web/server/AbstractMockServerSpec.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
import org.springframework.test.web.servlet.setup.MockMvcConfigurer;
2929

3030
/**
31-
* Base class for implementations of {@link RestTestClient.MockMvcServerSpec}
31+
* Base class for implementations of {@link RestTestClient.MockServerSpec}
3232
* that simply delegates to a {@link org.springframework.test.web.servlet.setup.ConfigurableMockMvcBuilder} supplied by
3333
* the concrete subclasses.
3434
*
3535
* @author Rob Worsnop
3636
* @param <B> the type of the concrete subclass spec
3737
*/
38-
abstract class AbstractMockMvcServerSpec<B extends RestTestClient.MockMvcServerSpec<B>>
39-
implements RestTestClient.MockMvcServerSpec<B> {
38+
abstract class AbstractMockServerSpec<B extends RestTestClient.MockServerSpec<B>>
39+
implements RestTestClient.MockServerSpec<B> {
4040

4141
@Override
4242
public <T extends B> T filters(Filter... filters) {

spring-test/src/main/java/org/springframework/test/web/server/ApplicationContextMockMvcSpec.java renamed to spring-test/src/main/java/org/springframework/test/web/server/ApplicationContextMockSpec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
*
2727
* @author Rob Worsnop
2828
*/
29-
class ApplicationContextMockMvcSpec extends AbstractMockMvcServerSpec<ApplicationContextMockMvcSpec> {
29+
class ApplicationContextMockSpec extends AbstractMockServerSpec<ApplicationContextMockSpec> {
3030
private final DefaultMockMvcBuilder mockMvcBuilder;
3131

32-
public ApplicationContextMockMvcSpec(WebApplicationContext context) {
32+
public ApplicationContextMockSpec(WebApplicationContext context) {
3333
this.mockMvcBuilder = MockMvcBuilders.webAppContextSetup(context);
3434
}
3535

spring-test/src/main/java/org/springframework/test/web/server/RestTestClient.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public interface RestTestClient {
145145
* to initialize {@link MockMvc}.
146146
*/
147147
static ControllerSpec bindToController(Object... controllers) {
148-
return new StandaloneMockMvcSpec(controllers);
148+
return new StandaloneMockSpec(controllers);
149149
}
150150

151151
/**
@@ -156,7 +156,7 @@ static ControllerSpec bindToController(Object... controllers) {
156156
* to initialize {@link MockMvc}.
157157
*/
158158
static RouterFunctionSpec bindToRouterFunction(RouterFunction<?>... routerFunctions) {
159-
return new RouterFunctionMockMvcSpec(routerFunctions);
159+
return new RouterFunctionMockSpec(routerFunctions);
160160
}
161161

162162
/**
@@ -167,8 +167,8 @@ static RouterFunctionSpec bindToRouterFunction(RouterFunction<?>... routerFuncti
167167
* {@link org.springframework.test.web.servlet.setup.MockMvcBuilders#webAppContextSetup(WebApplicationContext)}
168168
* to initialize {@code MockMvc}.
169169
*/
170-
static MockMvcServerSpec<?> bindToApplicationContext(WebApplicationContext context) {
171-
return new ApplicationContextMockMvcSpec(context);
170+
static MockServerSpec<?> bindToApplicationContext(WebApplicationContext context) {
171+
return new ApplicationContextMockSpec(context);
172172
}
173173

174174

@@ -207,7 +207,7 @@ static Builder bindToServer(ClientHttpRequestFactory requestFactory) {
207207
/**
208208
* Specification for customizing controller configuration.
209209
*/
210-
interface ControllerSpec extends MockMvcServerSpec<ControllerSpec> {
210+
interface ControllerSpec extends MockServerSpec<ControllerSpec> {
211211
/**
212212
* Register {@link org.springframework.web.bind.annotation.ControllerAdvice}
213213
* <p>This is delegated to
@@ -342,7 +342,7 @@ ControllerSpec mappedInterceptors(
342342
* {@linkplain RouterFunction router functions}
343343
* directly, and a simple facade around {@link RouterFunctionMockMvcBuilder}.
344344
*/
345-
interface RouterFunctionSpec extends MockMvcServerSpec<RouterFunctionSpec> {
345+
interface RouterFunctionSpec extends MockServerSpec<RouterFunctionSpec> {
346346

347347
/**
348348
* Set the message converters to use.
@@ -411,7 +411,7 @@ RouterFunctionSpec mappedInterceptors(
411411
*
412412
* @param <B> a self reference to the builder type
413413
*/
414-
interface MockMvcServerSpec<B extends MockMvcServerSpec<B>> {
414+
interface MockServerSpec<B extends MockServerSpec<B>> {
415415
/**
416416
* Add a global filter.
417417
* <p>This is delegated to

spring-test/src/main/java/org/springframework/test/web/server/RouterFunctionMockMvcSpec.java renamed to spring-test/src/main/java/org/springframework/test/web/server/RouterFunctionMockSpec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@
3636
*
3737
* @author Rob Worsnop
3838
*/
39-
class RouterFunctionMockMvcSpec extends AbstractMockMvcServerSpec<RouterFunctionSpec>
39+
class RouterFunctionMockSpec extends AbstractMockServerSpec<RouterFunctionSpec>
4040
implements RouterFunctionSpec {
4141

4242
private final RouterFunctionMockMvcBuilder mockMvcBuilder;
4343

44-
RouterFunctionMockMvcSpec(RouterFunction<?>... routerFunctions) {
44+
RouterFunctionMockSpec(RouterFunction<?>... routerFunctions) {
4545
this.mockMvcBuilder = MockMvcBuilders.routerFunctions(routerFunctions);
4646
}
4747

spring-test/src/main/java/org/springframework/test/web/server/StandaloneMockMvcSpec.java renamed to spring-test/src/main/java/org/springframework/test/web/server/StandaloneMockSpec.java

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,121 +44,121 @@
4444
*
4545
* @author Rob Worsnop
4646
*/
47-
class StandaloneMockMvcSpec extends AbstractMockMvcServerSpec<RestTestClient.ControllerSpec>
47+
class StandaloneMockSpec extends AbstractMockServerSpec<RestTestClient.ControllerSpec>
4848
implements RestTestClient.ControllerSpec {
4949

5050
private final StandaloneMockMvcBuilder mockMvcBuilder;
5151

52-
StandaloneMockMvcSpec(Object... controllers) {
52+
StandaloneMockSpec(Object... controllers) {
5353
this.mockMvcBuilder = MockMvcBuilders.standaloneSetup(controllers);
5454
}
5555

5656
@Override
57-
public StandaloneMockMvcSpec controllerAdvice(Object... controllerAdvice) {
57+
public StandaloneMockSpec controllerAdvice(Object... controllerAdvice) {
5858
this.mockMvcBuilder.setControllerAdvice(controllerAdvice);
5959
return this;
6060
}
6161

6262
@Override
63-
public StandaloneMockMvcSpec messageConverters(HttpMessageConverter<?>... messageConverters) {
63+
public StandaloneMockSpec messageConverters(HttpMessageConverter<?>... messageConverters) {
6464
this.mockMvcBuilder.setMessageConverters(messageConverters);
6565
return this;
6666
}
6767

6868
@Override
69-
public StandaloneMockMvcSpec validator(Validator validator) {
69+
public StandaloneMockSpec validator(Validator validator) {
7070
this.mockMvcBuilder.setValidator(validator);
7171
return this;
7272
}
7373

7474
@Override
75-
public StandaloneMockMvcSpec conversionService(FormattingConversionService conversionService) {
75+
public StandaloneMockSpec conversionService(FormattingConversionService conversionService) {
7676
this.mockMvcBuilder.setConversionService(conversionService);
7777
return this;
7878
}
7979

8080
@Override
81-
public StandaloneMockMvcSpec interceptors(HandlerInterceptor... interceptors) {
81+
public StandaloneMockSpec interceptors(HandlerInterceptor... interceptors) {
8282
mappedInterceptors(null, interceptors);
8383
return this;
8484
}
8585

8686
@Override
87-
public StandaloneMockMvcSpec mappedInterceptors(
87+
public StandaloneMockSpec mappedInterceptors(
8888
String @Nullable [] pathPatterns, HandlerInterceptor... interceptors) {
8989

9090
this.mockMvcBuilder.addMappedInterceptors(pathPatterns, interceptors);
9191
return this;
9292
}
9393

9494
@Override
95-
public StandaloneMockMvcSpec contentNegotiationManager(ContentNegotiationManager manager) {
95+
public StandaloneMockSpec contentNegotiationManager(ContentNegotiationManager manager) {
9696
this.mockMvcBuilder.setContentNegotiationManager(manager);
9797
return this;
9898
}
9999

100100
@Override
101-
public StandaloneMockMvcSpec asyncRequestTimeout(long timeout) {
101+
public StandaloneMockSpec asyncRequestTimeout(long timeout) {
102102
this.mockMvcBuilder.setAsyncRequestTimeout(timeout);
103103
return this;
104104
}
105105

106106
@Override
107-
public StandaloneMockMvcSpec customArgumentResolvers(HandlerMethodArgumentResolver... argumentResolvers) {
107+
public StandaloneMockSpec customArgumentResolvers(HandlerMethodArgumentResolver... argumentResolvers) {
108108
this.mockMvcBuilder.setCustomArgumentResolvers(argumentResolvers);
109109
return this;
110110
}
111111

112112
@Override
113-
public StandaloneMockMvcSpec customReturnValueHandlers(HandlerMethodReturnValueHandler... handlers) {
113+
public StandaloneMockSpec customReturnValueHandlers(HandlerMethodReturnValueHandler... handlers) {
114114
this.mockMvcBuilder.setCustomReturnValueHandlers(handlers);
115115
return this;
116116
}
117117

118118
@Override
119-
public StandaloneMockMvcSpec handlerExceptionResolvers(HandlerExceptionResolver... exceptionResolvers) {
119+
public StandaloneMockSpec handlerExceptionResolvers(HandlerExceptionResolver... exceptionResolvers) {
120120
this.mockMvcBuilder.setHandlerExceptionResolvers(exceptionResolvers);
121121
return this;
122122
}
123123

124124
@Override
125-
public StandaloneMockMvcSpec viewResolvers(ViewResolver... resolvers) {
125+
public StandaloneMockSpec viewResolvers(ViewResolver... resolvers) {
126126
this.mockMvcBuilder.setViewResolvers(resolvers);
127127
return this;
128128
}
129129

130130
@Override
131-
public StandaloneMockMvcSpec singleView(View view) {
131+
public StandaloneMockSpec singleView(View view) {
132132
this.mockMvcBuilder.setSingleView(view);
133133
return this;
134134
}
135135

136136
@Override
137-
public StandaloneMockMvcSpec localeResolver(LocaleResolver localeResolver) {
137+
public StandaloneMockSpec localeResolver(LocaleResolver localeResolver) {
138138
this.mockMvcBuilder.setLocaleResolver(localeResolver);
139139
return this;
140140
}
141141

142142
@Override
143-
public StandaloneMockMvcSpec flashMapManager(FlashMapManager flashMapManager) {
143+
public StandaloneMockSpec flashMapManager(FlashMapManager flashMapManager) {
144144
this.mockMvcBuilder.setFlashMapManager(flashMapManager);
145145
return this;
146146
}
147147

148148
@Override
149-
public StandaloneMockMvcSpec patternParser(PathPatternParser parser) {
149+
public StandaloneMockSpec patternParser(PathPatternParser parser) {
150150
this.mockMvcBuilder.setPatternParser(parser);
151151
return this;
152152
}
153153

154154
@Override
155-
public StandaloneMockMvcSpec placeholderValue(String name, String value) {
155+
public StandaloneMockSpec placeholderValue(String name, String value) {
156156
this.mockMvcBuilder.addPlaceholderValue(name, value);
157157
return this;
158158
}
159159

160160
@Override
161-
public StandaloneMockMvcSpec customHandlerMapping(Supplier<RequestMappingHandlerMapping> factory) {
161+
public StandaloneMockSpec customHandlerMapping(Supplier<RequestMappingHandlerMapping> factory) {
162162
this.mockMvcBuilder.setCustomHandlerMapping(factory);
163163
return this;
164164
}

spring-test/src/test/java/org/springframework/test/web/server/StandaloneMockMvcSpecTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,21 @@
2727
import org.springframework.web.bind.annotation.RestController;
2828

2929
/**
30-
* Tests for {@link StandaloneMockMvcSpec}.
30+
* Tests for {@link StandaloneMockSpec}.
3131
*
3232
* @author Rob Worsnop
3333
*/
3434
public class StandaloneMockMvcSpecTests {
3535

3636
@Test
3737
public void controller() {
38-
new StandaloneMockMvcSpec(new MyController()).build()
38+
new StandaloneMockSpec(new MyController()).build()
3939
.get().uri("/")
4040
.exchange()
4141
.expectStatus().isOk()
4242
.expectBody(String.class).isEqualTo("Success");
4343

44-
new StandaloneMockMvcSpec(new MyController()).build()
44+
new StandaloneMockSpec(new MyController()).build()
4545
.get().uri("")
4646
.exchange()
4747
.expectStatus().isOk()
@@ -50,7 +50,7 @@ public void controller() {
5050

5151
@Test
5252
public void controllerAdvice() {
53-
new StandaloneMockMvcSpec(new MyController())
53+
new StandaloneMockSpec(new MyController())
5454
.controllerAdvice(new MyControllerAdvice())
5555
.build()
5656
.get().uri("/exception")
@@ -61,7 +61,7 @@ public void controllerAdvice() {
6161

6262
@Test
6363
public void controllerAdviceWithClassArgument() {
64-
new StandaloneMockMvcSpec(MyController.class)
64+
new StandaloneMockSpec(MyController.class)
6565
.controllerAdvice(MyControllerAdvice.class)
6666
.build()
6767
.get().uri("/exception")

0 commit comments

Comments
 (0)