Polishing

Author: jhoeller

spring-core/src/main/java/org/springframework/core/ResolvableType.java

@@ -1192,12 +1192,17 @@ static ResolvableType forType(Type type, TypeProvider typeProvider, VariableReso
 		if (type == null) {
 			return NONE;
 		}
-		// Check the cache, we may have a ResolvableType that may have already been resolved
+
+		// Purge empty entries on access since we don't have a clean-up thread or the like.
 		cache.purgeUnreferencedEntries();
 
+		// For simple Class references, build the wrapper right away -
+		// no expensive resolution necessary, so not worth caching...
 		if (type instanceof Class<?>) {
 			return new ResolvableType(type, typeProvider, variableResolver, null);
 		}
+
+		// Check the cache - we may have a ResolvableType which has been resolved before...
 		ResolvableType key = new ResolvableType(type, typeProvider, variableResolver);
 		ResolvableType resolvableType = cache.get(key);
 		if (resolvableType == null) {

spring-core/src/main/java/org/springframework/util/AntPathMatcher.java

@@ -58,7 +58,9 @@ public class AntPathMatcher implements PathMatcher {
 	private static final Pattern VARIABLE_PATTERN = Pattern.compile("\\{[^/]+?\\}");
 
 
-	private String pathSeparator = DEFAULT_PATH_SEPARATOR;
+	private String pathSeparator;
+
+	private PathSeparatorPatternCache pathSeparatorPatternCache;
 
 	private boolean trimTokens = true;
 
@@ -68,13 +70,13 @@ public class AntPathMatcher implements PathMatcher {
 
 	final Map<String, AntPathStringMatcher> stringMatcherCache = new ConcurrentHashMap<String, AntPathStringMatcher>(256);
 
-	private PathSeparatorPatternCache pathSeparatorPatternCache = new PathSeparatorPatternCache(DEFAULT_PATH_SEPARATOR);
-
 
 	/**
 	 * Create a new instance with the {@link #DEFAULT_PATH_SEPARATOR}.
 	 */
 	public AntPathMatcher() {
+		this.pathSeparator = DEFAULT_PATH_SEPARATOR;
+		this.pathSeparatorPatternCache = new PathSeparatorPatternCache(DEFAULT_PATH_SEPARATOR);
 	}
 
 	/**
@@ -580,14 +582,13 @@ public boolean matchStrings(String str, Map<String, String> uriTemplateVariables
 	 * {@link #getPatternComparator(String)}.
 	 * <p>In order, the most "generic" pattern is determined by the following:
 	 * <ul>
-	 *     <li>if it's null or a capture all pattern (i.e. it is equal to "/**")</li>
-	 *     <li>if the other pattern is an actual match</li>
-	 *     <li>if it's a catch-all pattern (i.e. it ends with "**"</li>
-	 *     <li>if it's got more "*" than the other pattern</li>
-	 *     <li>if it's got more "{foo}" than the other pattern</li>
-	 *     <li>if it's shorter than the other pattern</li>
+	 * <li>if it's null or a capture all pattern (i.e. it is equal to "/**")</li>
+	 * <li>if the other pattern is an actual match</li>
+	 * <li>if it's a catch-all pattern (i.e. it ends with "**"</li>
+	 * <li>if it's got more "*" than the other pattern</li>
+	 * <li>if it's got more "{foo}" than the other pattern</li>
+	 * <li>if it's shorter than the other pattern</li>
 	 * </ul>
-	 * </p>
 	 */
 	protected static class AntPatternComparator implements Comparator<String> {
 
@@ -598,15 +599,13 @@ public AntPatternComparator(String path) {
 		}
 
 		/**
-		 * Compare two patterns to determine which should match first, i.e. which is the most specific
-		 * regarding the current path.
-		 *
+		 * Compare two patterns to determine which should match first, i.e. which
+		 * is the most specific regarding the current path.
 		 * @return a negative integer, zero, or a positive integer as pattern1 is
 		 * more specific, equally specific, or less specific than pattern2.
 		 */
 		@Override
 		public int compare(String pattern1, String pattern2) {
-
 			PatternInfo info1 = new PatternInfo(pattern1);
 			PatternInfo info2 = new PatternInfo(pattern2);
 
@@ -664,6 +663,7 @@ else if (info2.getUriVars() < info1.getUriVars()) {
 			return 0;
 		}
 
+
 		/**
 		 * Value class that holds information about the pattern, e.g. number of
 		 * occurrences of "*", "**", and "{" pattern elements.
@@ -684,7 +684,6 @@ private static class PatternInfo {
 
 			private Integer length;
 
-
 			public PatternInfo(String pattern) {
 				this.pattern = pattern;
 				if (this.pattern != null) {
@@ -769,8 +768,7 @@ private static class PathSeparatorPatternCache {
 
 		private final String endsOnDoubleWildCard;
 
-
-		private PathSeparatorPatternCache(String pathSeparator) {
+		public PathSeparatorPatternCache(String pathSeparator) {
 			this.endsOnWildCard = pathSeparator + "*";
 			this.endsOnDoubleWildCard = pathSeparator + "**";
 		}