Polishing contribution

Closes gh-35294

Author: rstoyanchev

spring-web/src/main/java/org/springframework/http/ProblemDetail.java

@@ -102,7 +102,8 @@ protected ProblemDetail() {
 
 	/**
 	 * Setter for the {@link #getType() problem type}.
-	 * <p>By default, this is not set. According to the spec, when not present, its value is assumed to be "about:blank"
+	 * <p>By default, this is not set. According to the spec, when not present,
+	 * the type is assumed to be "about:blank"
 	 * @param type the problem type
 	 */
 	public void setType(@Nullable URI type) {

spring-web/src/main/java/org/springframework/web/DefaultErrorResponseBuilder.java

@@ -85,7 +85,7 @@ private HttpHeaders getHeaders() {
 	}
 
 	@Override
-	public ErrorResponse.Builder type(URI type) {
+	public ErrorResponse.Builder type(@Nullable URI type) {
 		this.problemDetail.setType(type);
 		return this;
 	}

spring-web/src/main/java/org/springframework/web/ErrorResponseException.java

@@ -111,7 +111,7 @@ public HttpHeaders getHeaders() {
 	 * Set the {@link ProblemDetail#setType(URI) type} field of the response body.
 	 * @param type the problem type
 	 */
-	public void setType(URI type) {
+	public void setType(@Nullable URI type) {
 		this.body.setType(type);
 	}
 

spring-web/src/test/java/org/springframework/http/converter/json/ProblemDetailJacksonMixinTests.java

@@ -42,27 +42,25 @@ class ProblemDetailJacksonMixinTests {
 
 
 	@Test
-	void writeStatusAndHeaders() throws Exception {
+	void writeStatusAndHeaders() {
 		ProblemDetail detail = ProblemDetail.forStatusAndDetail(HttpStatus.BAD_REQUEST, "Missing header");
 		testWrite(detail,
 				"""
 				{
-					"type": "about:blank",
 					"title": "Bad Request",
 					"status": 400,
 					"detail": "Missing header"
 				}""");
 	}
 
 	@Test
-	void writeCustomProperty() throws Exception {
+	void writeCustomProperty() {
 		ProblemDetail detail = ProblemDetail.forStatusAndDetail(HttpStatus.BAD_REQUEST, "Missing header");
 		detail.setProperty("host", "abc.org");
 		detail.setProperty("user", null);
 
 		testWrite(detail, """
 				{
-					"type": "about:blank",
 					"title": "Bad Request",
 					"status": 400,
 					"detail": "Missing header",
@@ -72,7 +70,7 @@ void writeCustomProperty() throws Exception {
 	}
 
 	@Test
-	void readCustomProperty() throws Exception {
+	void readCustomProperty() {
 		ProblemDetail detail = this.mapper.readValue("""
 				{
 					"type": "about:blank",
@@ -93,7 +91,7 @@ void readCustomProperty() throws Exception {
 	}
 
 	@Test
-	void readCustomPropertyFromXml() throws Exception {
+	void readCustomPropertyFromXml() {
 		ObjectMapper xmlMapper = XmlMapper.builder().addMixIn(ProblemDetail.class, ProblemDetailJacksonMixin.class).build();
 		ProblemDetail detail = xmlMapper.readValue("""
 				<problem xmlns="urn:ietf:rfc:7807">
@@ -111,7 +109,7 @@ void readCustomPropertyFromXml() throws Exception {
 		assertThat(detail.getProperties()).containsEntry("host", "abc.org");
 	}
 
-	private void testWrite(ProblemDetail problemDetail, String expected) throws Exception {
+	private void testWrite(ProblemDetail problemDetail, String expected) {
 		String output = this.mapper.writeValueAsString(problemDetail);
 		JSONAssert.assertEquals(expected, output, false);
 	}

spring-webflux/src/test/java/org/springframework/web/reactive/DispatcherHandlerErrorTests.java

@@ -125,8 +125,7 @@ void noStaticResource() {
 				"detail":"No static resource non-existing.",\
 				"instance":"\\/resources\\/non-existing",\
 				"status":404,\
-				"title":"Not Found",\
-				"type":"about:blank"}\
+				"title":"Not Found"}\
 				""");
 	}
 

spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingExceptionHandlingIntegrationTests.java

@@ -125,8 +125,7 @@ void globalExceptionHandlerWithHandlerNotFound() throws Exception {
 					assertThat(ex.getResponseBodyAsString()).isEqualTo("{" +
 							"\"instance\":\"\\/no-such-handler\"," +
 							"\"status\":404," +
-							"\"title\":\"Not Found\"," +
-							"\"type\":\"about:blank\"}");
+							"\"title\":\"Not Found\"}");
 				});
 	}
 
@@ -142,8 +141,7 @@ void globalExceptionHandlerWithMissingRequestParameter() throws Exception {
 							"\"detail\":\"Required query parameter 'q' is not present.\"," +
 							"\"instance\":\"\\/missing-request-parameter\"," +
 							"\"status\":400," +
-							"\"title\":\"Bad Request\"," +
-							"\"type\":\"about:blank\"}");
+							"\"title\":\"Bad Request\"}");
 				});
 	}
 

spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseBodyResultHandlerTests.java

@@ -152,8 +152,7 @@ private void testProblemDetailMediaType(MockServerWebExchange exchange, MediaTyp
 				{\
 				"status":400,\
 				"instance":"\\/path",\
-				"title":"Bad Request",\
-				"type":"about:blank"\
+				"title":"Bad Request"\
 				}""");
 	}
 

spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java

@@ -244,8 +244,7 @@ void handleErrorResponse() {
 				{\
 				"instance":"\\/path",\
 				"status":400,\
-				"title":"Bad Request",\
-				"type":"about:blank"\
+				"title":"Bad Request"\
 				}""");
 	}
 
@@ -265,8 +264,7 @@ void handleProblemDetail() {
 				{\
 				"instance":"\\/path",\
 				"status":400,\
-				"title":"Bad Request",\
-				"type":"about:blank"\
+				"title":"Bad Request"\
 				}""");
 	}
 

spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestResponseBodyMethodProcessorTests.java

@@ -395,15 +395,13 @@ private void testProblemDetailMediaType(String expectedContentType) throws Excep
 							<status>400</status>
 							<instance>/path</instance>
 							<title>Bad Request</title>
-							<type>about:blank</type>
 						</problem>""")
 					.ignoreWhitespace()
 					.areIdentical();
 		}
 		else {
 			JSONAssert.assertEquals("""
 					{
-						"type":     "about:blank",
 						"title":    "Bad Request",
 						"status":   400,
 						"instance": "/path"

spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerIntegrationTests.java

@@ -144,8 +144,7 @@ void testNoResourceFoundException() throws Exception {
 				"detail":"No static resource non-existing.",\
 				"instance":"\\/cp\\/non-existing",\
 				"status":404,\
-				"title":"Not Found",\
-				"type":"about:blank"\
+				"title":"Not Found"\
 				}\
 				""");
 	}