Suppress warnings

sbrannen · sbrannen · commit 911d1f2dead1 · 2022-09-14T15:27:11.000+02:00
diff --git a/spring-context/src/test/java/org/springframework/context/annotation/Gh29105Tests.java b/spring-context/src/test/java/org/springframework/context/annotation/Gh29105Tests.java
@@ -47,6 +47,8 @@ void beanProviderWithParentContextReuseOrder() {
 		List<Class<?>> orderedTypes = child.getBeanProvider(MyService.class)
 				.orderedStream().map(Object::getClass).collect(Collectors.toList());
 		assertThat(orderedTypes).containsExactly(CustomService.class, DefaultService.class);
+		parent.close();
+		child.close();
 	}
 
 
@@ -78,4 +80,5 @@ DefaultService defaultService() {
 		}
 
 	}
+
 }
diff --git a/spring-core/src/main/java/org/springframework/aot/hint/ReflectionHints.java b/spring-core/src/main/java/org/springframework/aot/hint/ReflectionHints.java
@@ -210,6 +210,7 @@ public ReflectionHints registerConstructor(Constructor<?> constructor, Executabl
 	 * @deprecated in favor of {@link #registerConstructor(Constructor, ExecutableMode)}
 	 */
 	@Deprecated
+	@SuppressWarnings("deprecation")
 	public ReflectionHints registerConstructor(Constructor<?> constructor, Consumer<ExecutableHint.Builder> constructorHint) {
 		return registerType(TypeReference.of(constructor.getDeclaringClass()),
 				typeHint -> typeHint.withConstructor(mapParameters(constructor), constructorHint));
@@ -247,7 +248,7 @@ public ReflectionHints registerMethod(Method method, ExecutableMode mode) {
 	 * @deprecated in favor of {@link #registerMethod(Method, ExecutableMode)}
 	 */
 	@Deprecated
-
+	@SuppressWarnings("deprecation")
 	public ReflectionHints registerMethod(Method method, Consumer<ExecutableHint.Builder> methodHint) {
 		return registerType(TypeReference.of(method.getDeclaringClass()),
 				typeHint -> typeHint.withMethod(method.getName(), mapParameters(method), methodHint));
diff --git a/spring-web/src/test/java/org/springframework/http/client/support/InterceptingHttpAccessorTests.java b/spring-web/src/test/java/org/springframework/http/client/support/InterceptingHttpAccessorTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -30,7 +30,6 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-
 /**
  * Tests for {@link InterceptingHttpAccessor}.
  *
@@ -40,6 +39,7 @@ public class InterceptingHttpAccessorTests {
 
 	@Test
 	public void getInterceptors() {
+		@SuppressWarnings("resource")
 		TestInterceptingHttpAccessor accessor = new TestInterceptingHttpAccessor();
 		List<ClientHttpRequestInterceptor> interceptors = Arrays.asList(
 				new SecondClientHttpRequestInterceptor(),
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/AsyncIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/AsyncIntegrationTests.java
@@ -52,6 +52,7 @@ void basicTest(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
 		URI url = new URI("http://localhost:" + port);
+		@SuppressWarnings("resource")
 		ResponseEntity<String> response = new RestTemplate().exchange(RequestEntity.get(url).build(), String.class);
 
 		assertThat(response.getBody()).isEqualTo("hello");
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/CookieIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/CookieIntegrationTests.java
@@ -53,6 +53,7 @@ public void basicTest(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + port);
 		String header = "SID=31d4d96e407aad42; lang=en-US";
+		@SuppressWarnings("resource")
 		ResponseEntity<Void> response = new RestTemplate().exchange(
 				RequestEntity.get(url).header("Cookie", header).build(), Void.class);
 
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/EchoHandlerIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/EchoHandlerIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -49,6 +49,7 @@ protected EchoHandler createHttpHandler() {
 	public void echo(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 
 		byte[] body = randomBytes();
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/ErrorHandlerIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/ErrorHandlerIntegrationTests.java
@@ -49,6 +49,7 @@ protected HttpHandler createHttpHandler() {
 	void responseBodyError(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 		restTemplate.setErrorHandler(NO_OP_ERROR_HANDLER);
 
@@ -62,6 +63,7 @@ void responseBodyError(HttpServer httpServer) throws Exception {
 	void handlingError(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 		restTemplate.setErrorHandler(NO_OP_ERROR_HANDLER);
 
@@ -75,6 +77,7 @@ void handlingError(HttpServer httpServer) throws Exception {
 	void emptyPathSegments(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 		restTemplate.setErrorHandler(NO_OP_ERROR_HANDLER);
 
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/MultipartIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/MultipartIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -57,6 +57,7 @@ protected HttpHandler createHttpHandler() {
 	void getFormParts(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 		RequestEntity<MultiValueMap<String, Object>> request = RequestEntity
 				.post(new URI("http://localhost:" + port + "/form-parts"))
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/RandomHandlerIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/RandomHandlerIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -59,6 +59,7 @@ void random(HttpServer httpServer) throws Exception {
 
 		// TODO: fix Reactor support
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 
 		byte[] body = randomBytes();
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/ServerHttpRequestIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/ServerHttpRequestIntegrationTests.java
@@ -46,6 +46,7 @@ void checkUri(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + port + "/foo?param=bar");
 		RequestEntity<Void> request = RequestEntity.post(url).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<Void> response = new RestTemplate().exchange(request, Void.class);
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
 	}
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/WriteOnlyHandlerIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/WriteOnlyHandlerIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -54,6 +54,7 @@ protected WriteOnlyHandler createHttpHandler() {
 	void writeOnly(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 
 		this.body = randomBytes();
diff --git a/spring-web/src/test/java/org/springframework/http/server/reactive/ZeroCopyIntegrationTests.java b/spring-web/src/test/java/org/springframework/http/server/reactive/ZeroCopyIntegrationTests.java
@@ -61,6 +61,7 @@ void zeroCopy(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + port);
 		RequestEntity<?> request = RequestEntity.get(url).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<byte[]> response = new RestTemplate().exchange(request, byte[].class);
 
 		assertThat(response.hasBody()).isTrue();
diff --git a/spring-web/src/test/java/org/springframework/web/client/RestTemplateTests.java b/spring-web/src/test/java/org/springframework/web/client/RestTemplateTests.java
@@ -106,6 +106,7 @@ void setup() {
 
 	@Test // gh-29008
 	void defaultMessageConvertersWithKotlinSerialization() {
+		@SuppressWarnings("resource")
 		RestTemplate restTemplate = new RestTemplate();
 		List<HttpMessageConverter<?>> httpMessageConverters = restTemplate.getMessageConverters();
 		assertThat(httpMessageConverters).extracting("class").containsOnlyOnce(
diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/result/SimpleUrlHandlerMappingIntegrationTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/result/SimpleUrlHandlerMappingIntegrationTests.java
@@ -72,6 +72,7 @@ void requestToFooHandler(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + this.port + "/foo");
 		RequestEntity<Void> request = RequestEntity.get(url).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<byte[]> response = new RestTemplate().exchange(request, byte[].class);
 
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
@@ -84,6 +85,7 @@ public void requestToBarHandler(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + this.port + "/bar");
 		RequestEntity<Void> request = RequestEntity.get(url).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<byte[]> response = new RestTemplate().exchange(request, byte[].class);
 
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
@@ -96,13 +98,15 @@ void requestToHeaderSettingHandler(HttpServer httpServer) throws Exception {
 
 		URI url = new URI("http://localhost:" + this.port + "/header");
 		RequestEntity<Void> request = RequestEntity.get(url).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<byte[]> response = new RestTemplate().exchange(request, byte[].class);
 
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
 		assertThat(response.getHeaders().getFirst("foo")).isEqualTo("bar");
 	}
 
 	@ParameterizedHttpServerTest
+	@SuppressWarnings("resource")
 	void handlerNotFound(HttpServer httpServer) throws Exception {
 		startServer(httpServer);
 
diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ContextPathIntegrationTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ContextPathIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -55,6 +55,7 @@ void multipleWebFluxApps() throws Exception {
 		server.start();
 
 		try {
+			@SuppressWarnings("resource")
 			RestTemplate restTemplate = new RestTemplate();
 			String actual;
 
@@ -87,6 +88,7 @@ void servletPathMapping() throws Exception {
 
 		try {
 			String url = "http://localhost:" + server.getPort() + "/app/api/test";
+			@SuppressWarnings("resource")
 			String actual = new RestTemplate().getForObject(url, String.class);
 			assertThat(actual).isEqualTo("Tested in /app/api");
 		}
diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingViewResolutionIntegrationTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingViewResolutionIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -94,6 +94,7 @@ protected void prepareConnection(HttpURLConnection conn, String method) throws I
 
 		URI uri = new URI("http://localhost:" + this.port + "/redirect");
 		RequestEntity<Void> request = RequestEntity.get(uri).accept(MediaType.ALL).build();
+		@SuppressWarnings("resource")
 		ResponseEntity<Void> response = new RestTemplate(factory).exchange(request, Void.class);
 
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.SEE_OTHER);

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ void beanProviderWithParentContextReuseOrder() {`
`47`	`47`	`List<Class<?>> orderedTypes = child.getBeanProvider(MyService.class)`
`48`	`48`	`.orderedStream().map(Object::getClass).collect(Collectors.toList());`
`49`	`49`	`assertThat(orderedTypes).containsExactly(CustomService.class, DefaultService.class);`
	`50`	`+ parent.close();`
	`51`	`+ child.close();`
`50`	`52`	`}`
`51`	`53`
`52`	`54`
`@@ -78,4 +80,5 @@ DefaultService defaultService() {`
`78`	`80`	`}`
`79`	`81`
`80`	`82`	`}`
	`83`	`+`
`81`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ void checkUri(HttpServer httpServer) throws Exception {`
`46`	`46`
`47`	`47`	`URI url = new URI("http://localhost:" + port + "/foo?param=bar");`
`48`	`48`	`RequestEntity<Void> request = RequestEntity.post(url).build();`
	`49`	`+ @SuppressWarnings("resource")`
`49`	`50`	`ResponseEntity<Void> response = new RestTemplate().exchange(request, Void.class);`
`50`	`51`	`assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);`
`51`	`52`	`}`