Refine null-safety in the spring-jms module

Closes gh-34157

Author: sdeleuze

spring-core/src/main/java/org/springframework/util/CollectionUtils.java

@@ -289,7 +289,7 @@ public static boolean containsAny(Collection<?> source, Collection<?> candidates
 	 * or {@code null} if none or more than one such value found
 	 */
 	@SuppressWarnings("unchecked")
-	public static <T> @Nullable T findValueOfType(Collection<?> collection, @Nullable Class<T> type) {
+	public static <T> @Nullable T findValueOfType(@Nullable Collection<?> collection, @Nullable Class<T> type) {
 		if (isEmpty(collection)) {
 			return null;
 		}

spring-jms/src/main/java/org/springframework/jms/connection/ConnectionFactoryUtils.java

@@ -274,7 +274,7 @@ public boolean isSynchedLocalTransactionAllowed() {
 	 * @return the transactional Session, or {@code null} if none found
 	 * @throws JMSException in case of JMS failure
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	public static @Nullable Session doGetTransactionalSession(
 			ConnectionFactory connectionFactory, ResourceFactory resourceFactory, boolean startConnection)
 			throws JMSException {

spring-jms/src/main/java/org/springframework/jms/connection/JmsResourceHolder.java

@@ -215,7 +215,6 @@ public boolean containsSession(Session session) {
 	 * Return this resource holder's Session of the given type
 	 * for the given connection, or {@code null} if none.
 	 */
-	@SuppressWarnings("NullAway")
 	public <S extends Session> @Nullable S getSession(Class<S> sessionType, @Nullable Connection connection) {
 		Deque<Session> sessions =
 				(connection != null ? this.sessionsPerConnection.get(connection) : this.sessions);

spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java

@@ -323,7 +323,7 @@ private ConnectionFactory obtainTargetConnectionFactory() {
 	 * @throws jakarta.jms.JMSException if thrown by JMS API methods
 	 * @see #initConnection()
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lazy initialization
 	protected Connection getConnection() throws JMSException {
 		this.connectionLock.lock();
 		try {

spring-jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java

@@ -1434,7 +1434,7 @@ private void decreaseActiveInvokerCount() {
 			}
 		}
 
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Lazy initialization
 		private void initResourcesIfNecessary() throws JMSException {
 			if (getCacheLevel() <= CACHE_CONNECTION) {
 				updateRecoveryMarker();

spring-jms/src/main/java/org/springframework/jms/listener/SimpleMessageListenerContainer.java

@@ -312,7 +312,7 @@ protected void initializeConsumers() throws JMSException {
 	 * @throws JMSException if thrown by JMS methods
 	 * @see #executeListener
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	protected MessageConsumer createListenerConsumer(final Session session) throws JMSException {
 		Destination destination = getDestination();
 		if (destination == null) {
@@ -341,7 +341,7 @@ protected MessageConsumer createListenerConsumer(final Session session) throws J
 	 * @see #executeListener
 	 * @see #setExposeListenerSession
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	protected void processMessage(Message message, Session session) {
 		ConnectionFactory connectionFactory = getConnectionFactory();
 		boolean exposeResource = (connectionFactory != null && isExposeListenerSession());