Proper exception for controller method return types that do not work with MvcUriComponentsBuilder (e.g. final classes)

Issue: SPR-16710

Author: jhoeller

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilder.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -252,10 +252,8 @@ public static UriComponentsBuilder fromMethodName(UriComponentsBuilder builder,
 	 * controller.getAddressesForCountry("US")
 	 * builder = MvcUriComponentsBuilder.fromMethodCall(controller);
 	 * </pre>
-	 *
 	 * <p><strong>Note:</strong> This method extracts values from "Forwarded"
 	 * and "X-Forwarded-*" headers if found. See class-level docs.
-	 *
 	 * @param info either the value returned from a "mock" controller
 	 * invocation or the "mock" controller itself after an invocation
 	 * @return a UriComponents instance
@@ -725,6 +723,16 @@ public UriComponentsBuilder withMethod(Class<?> controllerType, Method method, O
 	}
 
 
+	public interface MethodInvocationInfo {
+
+		Class<?> getControllerType();
+
+		Method getControllerMethod();
+
+		Object[] getArgumentValues();
+	}
+
+
 	private static class ControllerMethodInvocationInterceptor
 			implements org.springframework.cglib.proxy.MethodInterceptor, MethodInterceptor {
 
@@ -737,35 +745,41 @@ private static class ControllerMethodInvocationInterceptor
 		private static final Method getControllerType =
 				ReflectionUtils.findMethod(MethodInvocationInfo.class, "getControllerType");
 
+		private final Class<?> controllerType;
+
 		private Method controllerMethod;
 
 		private Object[] argumentValues;
 
-		private Class<?> controllerType;
-
 		ControllerMethodInvocationInterceptor(Class<?> controllerType) {
 			this.controllerType = controllerType;
 		}
 
 		@Override
 		public Object intercept(Object obj, Method method, Object[] args, MethodProxy proxy) {
-			if (getControllerMethod.equals(method)) {
+			if (getControllerType.equals(method)) {
+				return this.controllerType;
+			}
+			else if (getControllerMethod.equals(method)) {
 				return this.controllerMethod;
 			}
 			else if (getArgumentValues.equals(method)) {
 				return this.argumentValues;
 			}
-			else if (getControllerType.equals(method)) {
-				return this.controllerType;
-			}
 			else if (ReflectionUtils.isObjectMethod(method)) {
 				return ReflectionUtils.invokeMethod(method, obj, args);
 			}
 			else {
 				this.controllerMethod = method;
 				this.argumentValues = args;
 				Class<?> returnType = method.getReturnType();
-				return (void.class == returnType ? null : returnType.cast(initProxy(returnType, this)));
+				try {
+					return (returnType == void.class ? null : returnType.cast(initProxy(returnType, this)));
+				}
+				catch (Throwable ex) {
+					throw new IllegalStateException(
+							"Failed to create proxy for controller method return type: " + method, ex);
+				}
 			}
 		}
 
@@ -776,16 +790,6 @@ public Object invoke(org.aopalliance.intercept.MethodInvocation inv) throws Thro
 	}
 
 
-	public interface MethodInvocationInfo {
-
-		Method getControllerMethod();
-
-		Object[] getArgumentValues();
-
-		Class<?> getControllerType();
-	}
-
-
 	public static class MethodArgumentBuilder {
 
 		private final Class<?> controllerType;