Skip to content

Commit 9e7ee0c

Browse files
committed
Deprecate setAllowResultAccessAfterCompletion and document it as broken
Closes gh-26557
1 parent 1cd994d commit 9e7ee0c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

spring-orm/src/main/java/org/springframework/orm/hibernate5/HibernateTransactionManager.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,11 @@
100100
* @author Juergen Hoeller
101101
* @since 4.2
102102
* @see #setSessionFactory
103-
* @see #setDataSource
104103
* @see SessionFactory#getCurrentSession()
105-
* @see DataSourceUtils#getConnection
106-
* @see DataSourceUtils#releaseConnection
107104
* @see org.springframework.jdbc.core.JdbcTemplate
108105
* @see org.springframework.jdbc.support.JdbcTransactionManager
109-
* @see org.springframework.transaction.jta.JtaTransactionManager
106+
* @see org.springframework.orm.jpa.JpaTransactionManager
107+
* @see org.springframework.orm.jpa.vendor.HibernateJpaDialect
110108
*/
111109
@SuppressWarnings("serial")
112110
public class HibernateTransactionManager extends AbstractPlatformTransactionManager
@@ -271,7 +269,11 @@ public void setPrepareConnection(boolean prepareConnection) {
271269
* @see Connection#setHoldability
272270
* @see ResultSet#HOLD_CURSORS_OVER_COMMIT
273271
* @see #disconnectOnCompletion(Session)
272+
* @deprecated as of 5.3.29 since Hibernate 5.x aggressively closes ResultSets on commit,
273+
* making it impossible to rely on ResultSet holdability. Also, Spring does not provide
274+
* an equivalent setting on {@link org.springframework.orm.jpa.JpaTransactionManager}.
274275
*/
276+
@Deprecated
275277
public void setAllowResultAccessAfterCompletion(boolean allowResultAccessAfterCompletion) {
276278
this.allowResultAccessAfterCompletion = allowResultAccessAfterCompletion;
277279
}

0 commit comments

Comments
 (0)