Polishing

Author: jhoeller

spring-core/src/main/java/org/springframework/util/xml/AbstractXMLEventReader.java

@@ -27,13 +27,15 @@
 
 /**
  * Abstract base class for {@code XMLEventReader}s.
+ *
  * @author Arjen Poutsma
  * @since 5.0
  */
 abstract class AbstractXMLEventReader implements XMLEventReader {
 
 	private boolean closed;
 
+
 	@Override
 	public Object next() {
 		try {
@@ -113,12 +115,17 @@ public Object getProperty(String name) throws IllegalArgumentException {
 		throw new IllegalArgumentException("Property not supported: [" + name + "]");
 	}
 
+	@Override
+	public void close() {
+		this.closed = true;
+	}
+
 	/**
 	 * Returns {@code true} if closed; {@code false} otherwise.
 	 * @see #close()
 	 */
 	protected boolean isClosed() {
-		return closed;
+		return this.closed;
 	}
 
 	/**
@@ -133,8 +140,4 @@ protected void checkIfClosed() throws XMLStreamException {
 		}
 	}
 
-	@Override
-	public void close() {
-		closed = true;
-	}
 }

spring-core/src/main/java/org/springframework/util/xml/ListBasedXMLEventReader.java

@@ -35,20 +35,22 @@ class ListBasedXMLEventReader extends AbstractXMLEventReader {
 
 	private int cursor = 0;
 
+
 	public ListBasedXMLEventReader(List<XMLEvent> events) {
 		Assert.notNull(events, "'events' must not be null");
 		this.events = Collections.unmodifiableList(events);
 	}
 
+
 	@Override
 	public boolean hasNext() {
-		return cursor != events.size();
+		return (this.cursor != this.events.size());
 	}
 
 	@Override
 	public XMLEvent nextEvent() {
-		if (cursor < events.size()) {
-			return events.get(cursor++);
+		if (this.cursor < this.events.size()) {
+			return this.events.get(this.cursor++);
 		}
 		else {
 			throw new NoSuchElementException();
@@ -57,8 +59,8 @@ public XMLEvent nextEvent() {
 
 	@Override
 	public XMLEvent peek() {
-		if (cursor < events.size()) {
-			return events.get(cursor);
+		if (this.cursor < this.events.size()) {
+			return this.events.get(this.cursor);
 		}
 		else {
 			return null;
@@ -70,4 +72,5 @@ public void close() {
 		super.close();
 		this.events.clear();
 	}
+
 }

spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java

@@ -17,6 +17,7 @@
 package org.springframework.transaction.interceptor;
 
 import java.lang.reflect.Method;
+import java.util.Map;
 import java.util.Properties;
 import java.util.concurrent.ConcurrentHashMap;
 
@@ -85,7 +86,7 @@ public abstract class TransactionAspectSupport implements BeanFactoryAware, Init
 			new NamedThreadLocal<>("Current aspect-driven transaction");
 
 
-	private final ConcurrentHashMap<Object, PlatformTransactionManager> transactionManagerCache =
+	private final Map<Object, PlatformTransactionManager> transactionManagerCache =
 			new ConcurrentHashMap<>();
 
 	/**
@@ -243,7 +244,7 @@ protected final BeanFactory getBeanFactory() {
 	public void afterPropertiesSet() {
 		if (getTransactionManager() == null && this.beanFactory == null) {
 			throw new IllegalStateException(
-					"Setting the property 'transactionManager' or running in a ListableBeanFactory is required");
+					"Setting the property 'transactionManager' or running in a BeanFactory is required");
 		}
 		if (this.transactionAttributeSource == null) {
 			throw new IllegalStateException(
@@ -449,17 +450,16 @@ protected TransactionInfo prepareTransactionInfo(PlatformTransactionManager tm,
 
 		TransactionInfo txInfo = new TransactionInfo(tm, txAttr, joinpointIdentification);
 		if (txAttr != null) {
-			// We need a transaction for this method
+			// We need a transaction for this method...
 			if (logger.isTraceEnabled()) {
 				logger.trace("Getting transaction for [" + txInfo.getJoinpointIdentification() + "]");
 			}
-			// The transaction manager will flag an error if an incompatible tx already exists
+			// The transaction manager will flag an error if an incompatible tx already exists.
 			txInfo.newTransactionStatus(status);
 		}
 		else {
-			// The TransactionInfo.hasTransaction() method will return
-			// false. We created it only to preserve the integrity of
-			// the ThreadLocal stack maintained in this class.
+			// The TransactionInfo.hasTransaction() method will return false. We created it only
+			// to preserve the integrity of the ThreadLocal stack maintained in this class.
 			if (logger.isTraceEnabled())
 				logger.trace("Don't need to create transaction for [" + joinpointIdentification +
 						"]: This method isn't transactional.");