Skip to content

Commit ae34a8c

Browse files
committed
basic JUnit 4.5 compatibility (accepting use of deprecated SPI)
1 parent 22d3272 commit ae34a8c

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

org.springframework.test/ivy.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<dependency org="javax.servlet" name="com.springsource.javax.servlet" rev="2.4.0" conf="provided->compile"/>
2626
<dependency org="javax.servlet" name="com.springsource.javax.servlet.jsp" rev="2.0.0" conf="provided->compile"/>
2727
<dependency org="org.junit" name="com.springsource.junit" rev="3.8.2" conf="optional->compile"/>
28-
<dependency org="org.junit" name="com.springsource.org.junit" rev="4.4.0" conf="optional->compile"/>
28+
<dependency org="org.junit" name="com.springsource.org.junit" rev="4.5.0" conf="optional->compile"/>
2929
<dependency org="org.apache.commons" name="com.springsource.org.apache.commons.logging" rev="1.1.1" conf="compile->compile"/>
3030
<dependency org="org.apache.taglibs" name="com.springsource.org.apache.taglibs.standard" rev="1.1.2" conf="optional->compile"/>
3131
<dependency org="org.aspectj" name="com.springsource.org.aspectj.weaver" rev="1.5.4" conf="optional->compile"/>

org.springframework.test/src/main/java/org/springframework/test/context/junit4/SpringJUnit4ClassRunner.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.junit.internal.runners.InitializationError;
2525
import org.junit.internal.runners.JUnit4ClassRunner;
2626
import org.junit.runner.Description;
27+
import org.junit.runner.notification.Failure;
2728
import org.junit.runner.notification.RunNotifier;
2829

2930
import org.springframework.test.annotation.ProfileValueUtils;
@@ -148,11 +149,11 @@ protected void invokeTestMethod(Method method, RunNotifier notifier) {
148149
testInstance = createTest();
149150
}
150151
catch (InvocationTargetException ex) {
151-
notifier.testAborted(description, ex.getCause());
152+
notifier.fireTestFailure(new Failure(description, ex.getCause()));
152153
return;
153154
}
154155
catch (Exception ex) {
155-
notifier.testAborted(description, ex);
156+
notifier.fireTestFailure(new Failure(description, ex));
156157
return;
157158
}
158159

org.springframework.test/src/main/java/org/springframework/test/context/junit4/SpringMethodRoadie.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929

3030
import org.apache.commons.logging.Log;
3131
import org.apache.commons.logging.LogFactory;
32-
import org.junit.Assume.AssumptionViolatedException;
3332
import org.junit.runner.Description;
3433
import org.junit.runner.notification.Failure;
3534
import org.junit.runner.notification.RunNotifier;
35+
import org.junit.internal.AssumptionViolatedException;
3636

3737
import org.springframework.test.annotation.Repeat;
3838
import org.springframework.test.annotation.Timed;

org.springframework.test/template.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Import-Template:
1313
org.apache.commons.logging.*;version="[1.1.1, 2.0.0)",
1414
org.apache.taglibs.standard.*;version="[1.1.2, 2.0.0)";resolution:=optional,
1515
org.aspectj.weaver.*;version="[1.5.4, 2.0.0)";resolution:=optional,
16-
org.junit.*;version="[4.4.0, 5.0.0)";resolution:=optional,
16+
org.junit.*;version="[4.5.0, 5.0.0)";resolution:=optional,
1717
org.springframework.*;version="[2.5.5.A, 2.5.5.A]";resolution:=optional,
1818
org.testng.*;version="[5.8.0, 6.0.0)";resolution:=optional
1919
Unversioned-Imports:

org.springframework.test/test.iml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@
7676
<orderEntry type="module-library">
7777
<library>
7878
<CLASSES>
79-
<root url="jar://$IVY_CACHE$/org.junit/com.springsource.org.junit/4.4.0/com.springsource.org.junit-4.4.0.jar!/" />
79+
<root url="jar://$IVY_CACHE$/org.junit/com.springsource.org.junit/4.5.0/com.springsource.org.junit-4.5.0.jar!/" />
8080
</CLASSES>
8181
<JAVADOC />
8282
<SOURCES>
83-
<root url="jar://$IVY_CACHE$/org.junit/com.springsource.org.junit/4.4.0/com.springsource.org.junit-sources-4.4.0.jar!/" />
83+
<root url="jar://$IVY_CACHE$/org.junit/com.springsource.org.junit/4.5.0/com.springsource.org.junit-sources-4.5.0.jar!/" />
8484
</SOURCES>
8585
</library>
8686
</orderEntry>

0 commit comments

Comments
 (0)