Fix JmsClient javadoc and add more test cases

Signed-off-by: NeatGuyCoding <[email protected]>

Author: NeatGuyCoding

spring-jms/src/main/java/org/springframework/jms/core/JmsClient.java

@@ -67,6 +67,7 @@ interface JmsClient {
 	/**
 	 * Create a new {@code JmsClient} for the given {@link ConnectionFactory}.
 	 * @param connectionFactory the factory to obtain JMS connections from
+	 * @return a new {@code JmsClient} instance
 	 */
 	static JmsClient create(ConnectionFactory connectionFactory) {
 		return new DefaultJmsClient(connectionFactory, null);
@@ -76,25 +77,28 @@ static JmsClient create(ConnectionFactory connectionFactory) {
 	 * Create a new {@code JmsClient} for the given {@link ConnectionFactory}.
 	 * @param connectionFactory the factory to obtain JMS connections from
 	 * @param messageConverter the message converter for payload objects
+	 * @return a new {@code JmsClient} instance
 	 */
 	static JmsClient create(ConnectionFactory connectionFactory, MessageConverter messageConverter) {
 		return new DefaultJmsClient(connectionFactory, messageConverter);
 	}
 
 	/**
-	 * Create a new {@code JmsClient} for the given {@link ConnectionFactory}.
+	 * Create a new {@code JmsClient} for the given {@link JmsOperations}.
 	 * @param jmsTemplate the {@link JmsTemplate} to use for performing operations
 	 * (can be a custom {@link JmsOperations} implementation as well)
+	 * @return a new {@code JmsClient} instance
 	 */
 	static JmsClient create(JmsOperations jmsTemplate) {
 		return new DefaultJmsClient(jmsTemplate, null);
 	}
 
 	/**
-	 * Create a new {@code JmsClient} for the given {@link ConnectionFactory}.
+	 * Create a new {@code JmsClient} for the given {@link JmsOperations}.
 	 * @param jmsTemplate the {@link JmsTemplate} to use for performing operations
 	 * (can be a custom {@link JmsOperations} implementation as well)
 	 * @param messageConverter the message converter for payload objects
+	 * @return a new {@code JmsClient} instance
 	 */
 	static JmsClient create(JmsOperations jmsTemplate, MessageConverter messageConverter) {
 		return new DefaultJmsClient(jmsTemplate, messageConverter);

spring-jms/src/test/java/org/springframework/jms/core/JmsClientTests.java

@@ -121,24 +121,28 @@ void convertAndSendPayloadName() throws JMSException {
 	}
 
 	@Test
-	void convertAndSendPayloadAndHeaders() {
+	void convertAndSendPayloadAndHeaders() throws JMSException {
 		Destination destination = new Destination() {};
 		Map<String, Object> headers = new HashMap<>();
 		headers.put("foo", "bar");
 
 		this.jmsClient.destination(destination).send("Hello", headers);
 		verify(this.jmsTemplate).send(eq(destination), this.messageCreator.capture());
 		assertTextMessage(this.messageCreator.getValue()); // see createTextMessage
+		TextMessage jmsMessage = createTextMessage(this.messageCreator.getValue());
+		assertThat(jmsMessage.getStringProperty("foo")).isEqualTo("bar");
 	}
 
 	@Test
-	void convertAndSendPayloadAndHeadersName() {
+	void convertAndSendPayloadAndHeadersName() throws JMSException {
 		Map<String, Object> headers = new HashMap<>();
 		headers.put("foo", "bar");
 
 		this.jmsClient.destination("myQueue").send("Hello", headers);
 		verify(this.jmsTemplate).send(eq("myQueue"), this.messageCreator.capture());
 		assertTextMessage(this.messageCreator.getValue()); // see createTextMessage
+		TextMessage jmsMessage = createTextMessage(this.messageCreator.getValue());
+		assertThat(jmsMessage.getStringProperty("foo")).isEqualTo("bar");
 	}
 
 	@Test