Remove HttpRequestPathHelper

The use of the undecoded URL path by default and the removal of suffix
pattern matching effectively means HttpRequestPathHelper is no longer
needed.

Issue: SPR-15640, SPR-15639

Author: rstoyanchev

spring-web/src/main/java/org/springframework/web/server/support/HttpRequestPathHelper.java

@@ -18,7 +18,6 @@
 
 import org.springframework.lang.Nullable;
 import org.springframework.util.PathMatcher;
-import org.springframework.web.server.support.HttpRequestPathHelper;
 import org.springframework.web.util.pattern.ParsingPathMatcher;
 
 /**
@@ -35,8 +34,6 @@ public class PathMatchConfigurer {
 
 	private Boolean registeredSuffixPatternMatch;
 
-	private HttpRequestPathHelper pathHelper;
-
 	private PathMatcher pathMatcher;
 
 
@@ -73,15 +70,6 @@ public PathMatchConfigurer setUseRegisteredSuffixPatternMatch(Boolean registered
 		return this;
 	}
 
-	/**
-	 * Set a {@code HttpRequestPathHelper} for the resolution of lookup paths.
-	 * <p>Default is {@code HttpRequestPathHelper}.
-	 */
-	public PathMatchConfigurer setPathHelper(HttpRequestPathHelper pathHelper) {
-		this.pathHelper = pathHelper;
-		return this;
-	}
-
 	/**
 	 * Set the PathMatcher for matching URL paths against registered URL patterns.
 	 * <p>The default is a {@link org.springframework.web.util.pattern.ParsingPathMatcher}.
@@ -106,11 +94,6 @@ protected Boolean isUseRegisteredSuffixPatternMatch() {
 		return this.registeredSuffixPatternMatch;
 	}
 
-	@Nullable
-	protected HttpRequestPathHelper getPathHelper() {
-		return this.pathHelper;
-	}
-
 	@Nullable
 	public PathMatcher getPathMatcher() {
 		if (this.pathMatcher instanceof ParsingPathMatcher && (this.trailingSlashMatch || this.suffixPatternMatch)) {

spring-web/src/main/java/org/springframework/web/server/support/package-info.java

@@ -133,16 +133,10 @@ public RequestMappingHandlerMapping requestMappingHandlerMapping() {
 		if (useTrailingSlashMatch != null) {
 			mapping.setUseTrailingSlashMatch(useTrailingSlashMatch);
 		}
-
-		HttpRequestPathHelper pathHelper = configurer.getPathHelper();
-		if (pathHelper != null) {
-			mapping.setPathHelper(pathHelper);
-		}
 		PathMatcher pathMatcher = configurer.getPathMatcher();
 		if (pathMatcher != null) {
 			mapping.setPathMatcher(pathMatcher);
 		}
-
 		return mapping;
 	}
 
@@ -251,9 +245,6 @@ public HandlerMapping resourceHandlerMapping() {
 			if (pathMatchConfigurer.getPathMatcher() != null) {
 				handlerMapping.setPathMatcher(pathMatchConfigurer.getPathMatcher());
 			}
-			if (pathMatchConfigurer.getPathHelper() != null) {
-				handlerMapping.setPathHelper(pathMatchConfigurer.getPathHelper());
-			}
 		}
 		else {
 			handlerMapping = new EmptyHandlerMapping();

spring-web/src/test/java/org/springframework/web/server/support/HttpRequestPathHelperTests.java

@@ -34,7 +34,6 @@
 import org.springframework.web.reactive.HandlerMapping;
 import org.springframework.web.server.ServerWebExchange;
 import org.springframework.web.server.WebHandler;
-import org.springframework.web.server.support.HttpRequestPathHelper;
 import org.springframework.web.util.pattern.ParsingPathMatcher;
 
 /**
@@ -53,8 +52,6 @@ public abstract class AbstractHandlerMapping extends ApplicationObjectSupport im
 
 	private int order = Integer.MAX_VALUE;  // default: same as non-Ordered
 
-	private HttpRequestPathHelper pathHelper = new HttpRequestPathHelper();
-
 	private PathMatcher pathMatcher = new ParsingPathMatcher();
 
 	private final UrlBasedCorsConfigurationSource globalCorsConfigSource = new UrlBasedCorsConfigurationSource();
@@ -76,33 +73,6 @@ public final int getOrder() {
 		return this.order;
 	}
 
-	/**
-	 * Set if the path should be URL-decoded. This sets the same property on the
-	 * underlying path helper.
-	 * @see HttpRequestPathHelper#setUrlDecode(boolean)
-	 */
-	public void setUrlDecode(boolean urlDecode) {
-		this.pathHelper.setUrlDecode(urlDecode);
-	}
-
-	/**
-	 * Set the {@link HttpRequestPathHelper} to use for resolution of lookup
-	 * paths. Use this to override the default implementation with a custom
-	 * subclass or to share common path helper settings across multiple
-	 * HandlerMappings.
-	 */
-	public void setPathHelper(HttpRequestPathHelper pathHelper) {
-		this.pathHelper = pathHelper;
-	}
-
-	/**
-	 * Return the {@link HttpRequestPathHelper} implementation to use for
-	 * resolution of lookup paths.
-	 */
-	public HttpRequestPathHelper getPathHelper() {
-		return this.pathHelper;
-	}
-
 	/**
 	 * Set the PathMatcher implementation to use for matching URL paths
 	 * against registered URL patterns.