Revert "Implement SessionFactoryImplementor in SF proxies"

This reverts commit 08ccd19.

Issue: SPR-8469

Author: cbeams

org.springframework.integration-tests/src/test/java/org/springframework/orm/hibernate3/HibernateSessionFactoryConfigurationTests.java

@@ -33,7 +33,6 @@
 import org.hibernate.Transaction;
 import org.hibernate.cfg.AnnotationConfiguration;
 import org.hibernate.classic.Session;
-import org.hibernate.engine.SessionFactoryImplementor;
 import org.junit.Ignore;
 import org.junit.Test;
 import org.springframework.beans.factory.BeanCreationException;
@@ -132,11 +131,10 @@ public void usingSessionFactoryBuilder_withLateCustomConfigurationClass() throws
 	}
 
 	@Test
-	public void builtSessionFactoryIsProxyImplementingDisposableBeanAndSessionFactoryImplementor() {
+	public void builtSessionFactoryIsDisposableBeanProxy() {
 		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext(AnnotationSessionFactoryConfig.class);
 		SessionFactory sessionFactory = ctx.getBean(SessionFactory.class);
 		assertThat(sessionFactory, instanceOf(DisposableBean.class));
-		assertThat(sessionFactory, instanceOf(SessionFactoryImplementor.class));
 		assertThat(sessionFactory.toString(), startsWith("DisposableBean proxy for SessionFactory"));
 		ctx.close();
 		assertTrue("SessionFactory was not closed as expected", sessionFactory.isClosed());

org.springframework.orm/src/main/java/org/springframework/orm/hibernate3/SessionFactoryBuilderSupport.java

@@ -232,9 +232,8 @@ public SessionFactoryBuilderSupport(DataSource dataSource) {
 
 	/**
 	 * Build the underlying Hibernate SessionFactory.
-	 * @return the {@code SessionFactory}, potentially wrapped as a
-	 * {@code DisposableBean} and/or transaction-aware proxy before it is exposed to the
-	 * application.
+	 * @return the raw SessionFactory (potentially to be wrapped with a
+	 * transaction-aware proxy before it is exposed to the application)
 	 * @throws Exception in case of initialization failure
 	 */
 	public SessionFactory buildSessionFactory() throws Exception {
@@ -245,9 +244,8 @@ public SessionFactory buildSessionFactory() throws Exception {
 
 	/**
 	 * Populate the underlying {@code Configuration} instance with the various
-	 * properties of this builder, then return the raw session factory resulting from
-	 * calling {@link Configuration#buildSessionFactory()}. Customization may be performed
-	 * through {@code pre*} and {@code post*} methods.
+	 * properties of this builder. Customization may be performed through
+	 * {@code pre*} and {@code post*} methods.
 	 * @see #preBuildSessionFactory()
 	 * @see #postProcessMappings()
 	 * @see #postBuildSessionFactory()
@@ -555,17 +553,15 @@ protected void postBuildSessionFactory() {
 	 * <p>Subclasses may override this to implement transaction awareness through
 	 * a {@code SessionFactory} proxy for example, or even to avoid creation of the
 	 * {@code DisposableBean} proxy altogether.
-	 * @param rawSf the raw {@code SessionFactory} as built by {@link #doBuildSessionFactory()}
-	 * @return a proxied {@code SessionFactory} if wrapping was necessary, otherwise the
-	 * original given 'raw' {@code SessionFactory} object.
+	 * @param rawSf the raw {@code SessionFactory} as built by {@link #buildSessionFactory()}
+	 * @return the {@code SessionFactory} reference to expose
 	 * @see #buildSessionFactory()
 	 */
 	protected SessionFactory wrapSessionFactoryIfNecessary(final SessionFactory rawSf) {
 		return (SessionFactory) Proxy.newProxyInstance(
 			this.beanClassLoader,
 			new Class<?>[] {
 				SessionFactory.class,
-				SessionFactoryImplementor.class,
 				DisposableBean.class
 			},
 			new InvocationHandler() {