Skip to content

Commit bb5a53f

Browse files
committed
Update websocket xml namespace attributes
1 parent cea049b commit bb5a53f

File tree

5 files changed

+28
-39
lines changed

5 files changed

+28
-39
lines changed

spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -304,25 +304,25 @@ else if (brokerRelayElem != null) {
304304
if(!relayPort.isEmpty()) {
305305
mpvs.add("relayPort", Integer.valueOf(relayPort));
306306
}
307-
String systemLogin = brokerRelayElem.getAttribute("system-login");
308-
if(!systemLogin.isEmpty()) {
309-
mpvs.add("systemLogin",systemLogin);
307+
String attrValue = brokerRelayElem.getAttribute("login");
308+
if(!attrValue.isEmpty()) {
309+
mpvs.add("systemLogin",attrValue);
310310
}
311-
String systemPasscode = brokerRelayElem.getAttribute("system-passcode");
312-
if(!systemPasscode.isEmpty()) {
313-
mpvs.add("systemPasscode",systemPasscode);
311+
attrValue = brokerRelayElem.getAttribute("passcode");
312+
if(!attrValue.isEmpty()) {
313+
mpvs.add("systemPasscode", attrValue);
314314
}
315-
String systemHeartbeatSendInterval = brokerRelayElem.getAttribute("system-heartbeat-send-interval");
316-
if(!systemHeartbeatSendInterval.isEmpty()) {
317-
mpvs.add("systemHeartbeatSendInterval",Long.parseLong(systemHeartbeatSendInterval));
315+
attrValue = brokerRelayElem.getAttribute("heartbeat-send-interval");
316+
if(!attrValue.isEmpty()) {
317+
mpvs.add("systemHeartbeatSendInterval", Long.parseLong(attrValue));
318318
}
319-
String systemHeartbeatReceiveInterval = brokerRelayElem.getAttribute("system-heartbeat-receive-interval");
320-
if(!systemHeartbeatReceiveInterval.isEmpty()) {
321-
mpvs.add("systemHeartbeatReceiveInterval",Long.parseLong(systemHeartbeatReceiveInterval));
319+
attrValue = brokerRelayElem.getAttribute("heartbeat-receive-interval");
320+
if(!attrValue.isEmpty()) {
321+
mpvs.add("systemHeartbeatReceiveInterval", Long.parseLong(attrValue));
322322
}
323-
String virtualHost = brokerRelayElem.getAttribute("virtual-host");
324-
if(!virtualHost.isEmpty()) {
325-
mpvs.add("virtualHost",virtualHost);
323+
attrValue = brokerRelayElem.getAttribute("virtual-host");
324+
if(!attrValue.isEmpty()) {
325+
mpvs.add("virtualHost", attrValue);
326326
}
327327

328328
Class<?> handlerType = StompBrokerRelayMessageHandler.class;

spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketNamespaceUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static RuntimeBeanReference registerSockJsService(Element element, String
6767

6868
// TODO: polish the way constructor arguments are set
6969

70-
String customTaskSchedulerName = sockJsElement.getAttribute("task-scheduler");
70+
String customTaskSchedulerName = sockJsElement.getAttribute("scheduler");
7171
if (!customTaskSchedulerName.isEmpty()) {
7272
cavs.addIndexedArgumentValue(0, new RuntimeBeanReference(customTaskSchedulerName));
7373
}
@@ -126,7 +126,7 @@ public static RuntimeBeanReference registerSockJsService(Element element, String
126126
if (!attrValue.isEmpty()) {
127127
sockJsServiceDef.getPropertyValues().add("disconnectDelay", Long.valueOf(attrValue));
128128
}
129-
attrValue = sockJsElement.getAttribute("http-message-cache-size");
129+
attrValue = sockJsElement.getAttribute("message-cache-size");
130130
if (!attrValue.isEmpty()) {
131131
sockJsServiceDef.getPropertyValues().add("httpMessageCacheSize", Integer.valueOf(attrValue));
132132
}

spring-websocket/src/main/resources/org/springframework/web/socket/config/spring-websocket-4.0.xsd

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,22 +100,22 @@
100100
</xsd:attribute>
101101
<xsd:attribute name="disconnect-delay" type="xsd:long">
102102
</xsd:attribute>
103-
<xsd:attribute name="http-message-cache-size" type="xsd:long">
103+
<xsd:attribute name="message-cache-size" type="xsd:long">
104104
</xsd:attribute>
105105
<xsd:attribute name="websocket-enabled" type="xsd:boolean">
106106
</xsd:attribute>
107-
<xsd:attribute name="task-scheduler" type="xsd:string">
107+
<xsd:attribute name="scheduler" type="xsd:string">
108108
</xsd:attribute>
109109
</xsd:complexType>
110110

111111
<xsd:complexType name="stomp-broker-relay">
112112
<xsd:attribute name="prefix" type="xsd:string"></xsd:attribute>
113113
<xsd:attribute name="relay-host" type="xsd:string"></xsd:attribute>
114114
<xsd:attribute name="relay-port" type="xsd:integer"></xsd:attribute>
115-
<xsd:attribute name="system-login" type="xsd:string"></xsd:attribute>
116-
<xsd:attribute name="system-passcode" type="xsd:string"></xsd:attribute>
117-
<xsd:attribute name="system-heartbeat-send-interval" type="xsd:long"></xsd:attribute>
118-
<xsd:attribute name="system-heartbeat-receive-interval" type="xsd:long"></xsd:attribute>
115+
<xsd:attribute name="login" type="xsd:string"></xsd:attribute>
116+
<xsd:attribute name="passcode" type="xsd:string"></xsd:attribute>
117+
<xsd:attribute name="heartbeat-send-interval" type="xsd:long"></xsd:attribute>
118+
<xsd:attribute name="heartbeat-receive-interval" type="xsd:long"></xsd:attribute>
119119
<xsd:attribute name="auto-startup" type="xsd:boolean"></xsd:attribute>
120120
<xsd:attribute name="virtual-host" type="xsd:string"></xsd:attribute>
121121
</xsd:complexType>

spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-broker-relay.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,8 @@
99
<websocket:handshake-handler ref="myHandler"/>
1010
<websocket:sockjs/>
1111
</websocket:stomp-endpoint>
12-
<websocket:stomp-broker-relay
13-
prefix="/topic,/queue"
14-
relay-host="relayhost"
15-
relay-port="1234"
16-
system-login="login"
17-
system-passcode="pass"
18-
system-heartbeat-send-interval="5000"
19-
system-heartbeat-receive-interval="5000"
12+
<websocket:stomp-broker-relay prefix="/topic,/queue" relay-host="relayhost" relay-port="1234"
13+
login="login" passcode="pass" heartbeat-send-interval="5000" heartbeat-receive-interval="5000"
2014
virtual-host="spring.io"/>
2115
</websocket:message-broker>
2216

spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-handlers-sockjs-attributes.xml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,9 @@
77

88
<websocket:handlers >
99
<websocket:mapping path="/test" handler="testHandler"/>
10-
<websocket:sockjs task-scheduler="testTaskScheduler"
11-
name="testSockJsService"
12-
websocket-enabled="false"
13-
session-cookie-needed="false"
14-
stream-bytes-limit="2048"
15-
disconnect-delay="256"
16-
http-message-cache-size="1024"
17-
heartbeat-time="20">
10+
<websocket:sockjs name="testSockJsService" scheduler="testTaskScheduler" websocket-enabled="false"
11+
session-cookie-needed="false" stream-bytes-limit="2048" disconnect-delay="256"
12+
message-cache-size="1024" heartbeat-time="20">
1813
<websocket:transport-handlers register-defaults="false">
1914
<bean class="org.springframework.web.socket.sockjs.transport.handler.XhrPollingTransportHandler"/>
2015
<ref bean="xhrStreamingTransportHandler"/>

0 commit comments

Comments
 (0)