Skip to content

Commit bbe1301

Browse files
committed
Remove -XX:MaxHeapSize=256m from default GRADLE_OPTS
This setting was causing failures in the CI build, and was not present prior to the recent updates to gradle wrapper generation. This commit also simplifies the gradle wrapper customizations by placing the logic in a doLast block within the original 'wrapper' task, as to creating a second wrapper task and extending from the first.
1 parent c0baea5 commit bbe1301

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

build.gradle

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -802,15 +802,15 @@ configure(rootProject) {
802802
task wrapper(type: Wrapper) {
803803
description = 'Generates gradlew[.bat] scripts'
804804
gradleVersion = '1.2'
805-
}
806-
}
807805

808-
def defaultWrapper = tasks["wrapper"]
809-
task wrapper(overwrite: true, dependsOn: defaultWrapper) << {
810-
def gradleOpts = "-XX:MaxPermSize=1024m -Xmx1024m -XX:MaxHeapSize=256m"
811-
File wrapperFile = file('gradlew')
812-
wrapperFile.text = wrapperFile.text.replace("DEFAULT_JVM_OPTS=", "GRADLE_OPTS=\"$gradleOpts \$GRADLE_OPTS\"\nDEFAULT_JVM_OPTS=")
813-
File wrapperBatFile = file('gradlew.bat')
814-
wrapperBatFile.text = wrapperBatFile.text.replace("set DEFAULT_JVM_OPTS=", "set GRADLE_OPTS=$gradleOpts %GRADLE_OPTS%\nset DEFAULT_JVM_OPTS=")
806+
doLast() {
807+
def gradleOpts = "-XX:MaxPermSize=1024m -Xmx1024m"
808+
File wrapperFile = file('gradlew')
809+
wrapperFile.text = wrapperFile.text.replace("DEFAULT_JVM_OPTS=",
810+
"GRADLE_OPTS=\"$gradleOpts \$GRADLE_OPTS\"\nDEFAULT_JVM_OPTS=")
811+
File wrapperBatFile = file('gradlew.bat')
812+
wrapperBatFile.text = wrapperBatFile.text.replace("set DEFAULT_JVM_OPTS=",
813+
"set GRADLE_OPTS=$gradleOpts %GRADLE_OPTS%\nset DEFAULT_JVM_OPTS=")
814+
}
815+
}
815816
}
816-

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#Wed Oct 31 17:27:34 PDT 2012
1+
#Thu Nov 01 11:02:41 CET 2012
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME

gradlew

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
##############################################################################
88

99
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
10-
GRADLE_OPTS="-XX:MaxPermSize=1024m -Xmx1024m -XX:MaxHeapSize=256m $GRADLE_OPTS"
10+
GRADLE_OPTS="-XX:MaxPermSize=1024m -Xmx1024m $GRADLE_OPTS"
1111
DEFAULT_JVM_OPTS=""
1212

1313
APP_NAME="Gradle"

gradlew.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
if "%OS%"=="Windows_NT" setlocal
1010

1111
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
12-
set GRADLE_OPTS=-XX:MaxPermSize=1024m -Xmx1024m -XX:MaxHeapSize=256m %GRADLE_OPTS%
12+
set GRADLE_OPTS=-XX:MaxPermSize=1024m -Xmx1024m %GRADLE_OPTS%
1313
set DEFAULT_JVM_OPTS=
1414

1515
set DIRNAME=%~dp0

0 commit comments

Comments
 (0)