Consistent logging of resolved exceptions

Issue: SPR-17178

Author: rstoyanchev

spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerExceptionResolver.java

@@ -132,12 +132,16 @@ public ModelAndView resolveException(
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler, Exception ex) {
 
 		if (shouldApplyTo(request, handler)) {
-			if (this.logger.isDebugEnabled()) {
-				this.logger.debug("Resolving exception from handler [" + handler + "]: " + ex);
-			}
 			prepareResponse(ex, response);
 			ModelAndView result = doResolveException(request, response, handler, ex);
 			if (result != null) {
+
+				// Print warn message, when warn logger is not enabled..
+				if (logger.isWarnEnabled() && (this.warnLogger == null || !this.warnLogger.isWarnEnabled())) {
+					logger.warn("Resolved [" + ex + "]" + (result.isEmpty() ? "" : " to " + result));
+				}
+
+				// warnLogger with full stack trace (requires explicit config)..
 				logException(ex, request);
 			}
 			return result;

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/support/DefaultHandlerExceptionResolver.java

@@ -252,7 +252,6 @@ else if (ex instanceof AsyncRequestTimeoutException) {
 	protected ModelAndView handleHttpRequestMethodNotSupported(HttpRequestMethodNotSupportedException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
-		pageNotFoundLogger.warn(ex.getMessage());
 		String[] supportedMethods = ex.getSupportedMethods();
 		if (supportedMethods != null) {
 			response.setHeader("Allow", StringUtils.arrayToDelimitedString(supportedMethods, ", "));
@@ -376,9 +375,6 @@ protected ModelAndView handleServletRequestBindingException(ServletRequestBindin
 	protected ModelAndView handleConversionNotSupported(ConversionNotSupportedException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
-		if (logger.isWarnEnabled()) {
-			logger.warn("Failed to convert request element: " + ex);
-		}
 		sendServerError(ex, request, response);
 		return new ModelAndView();
 	}
@@ -397,9 +393,6 @@ protected ModelAndView handleConversionNotSupported(ConversionNotSupportedExcept
 	protected ModelAndView handleTypeMismatch(TypeMismatchException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
-		if (logger.isWarnEnabled()) {
-			logger.warn("Failed to bind request element: " + ex);
-		}
 		response.sendError(HttpServletResponse.SC_BAD_REQUEST);
 		return new ModelAndView();
 	}
@@ -420,9 +413,6 @@ protected ModelAndView handleTypeMismatch(TypeMismatchException ex,
 	protected ModelAndView handleHttpMessageNotReadable(HttpMessageNotReadableException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
-		if (logger.isWarnEnabled()) {
-			logger.warn("Failed to read HTTP message: " + ex);
-		}
 		response.sendError(HttpServletResponse.SC_BAD_REQUEST);
 		return new ModelAndView();
 	}
@@ -444,9 +434,6 @@ protected ModelAndView handleHttpMessageNotReadable(HttpMessageNotReadableExcept
 	protected ModelAndView handleHttpMessageNotWritable(HttpMessageNotWritableException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
-		if (logger.isWarnEnabled()) {
-			logger.warn("Failed to write HTTP message: " + ex);
-		}
 		sendServerError(ex, request, response);
 		return new ModelAndView();
 	}
@@ -520,6 +507,7 @@ protected ModelAndView handleBindException(BindException ex, HttpServletRequest
 	protected ModelAndView handleNoHandlerFoundException(NoHandlerFoundException ex,
 			HttpServletRequest request, HttpServletResponse response, @Nullable Object handler) throws IOException {
 
+		pageNotFoundLogger.warn(ex.getMessage());
 		response.sendError(HttpServletResponse.SC_NOT_FOUND);
 		return new ModelAndView();
 	}
@@ -542,8 +530,8 @@ protected ModelAndView handleAsyncRequestTimeoutException(AsyncRequestTimeoutExc
 		if (!response.isCommitted()) {
 			response.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE);
 		}
-		else if (logger.isDebugEnabled()) {
-			logger.debug("Async timeout for " + request.getMethod() + " [" + request.getRequestURI() + "]");
+		else {
+			logger.warn("Async request timed out");
 		}
 		return new ModelAndView();
 	}