Skip to content

Commit c72dd1f

Browse files
committed
Change "!void" pointcut expression to "int" for AspectJ 1.9.20
1 parent 43bd789 commit c72dd1f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

spring-aop/src/test/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactoryTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ void perTargetAspect() throws Exception {
127127
}
128128

129129
@Test
130-
void multiplePerTargetAspects() throws Exception {
130+
void multiplePerTargetAspects() {
131131
TestBean target = new TestBean();
132132
int realAge = 65;
133133
target.setAge(realAge);
@@ -153,7 +153,7 @@ void multiplePerTargetAspects() throws Exception {
153153
}
154154

155155
@Test
156-
void multiplePerTargetAspectsWithOrderAnnotation() throws Exception {
156+
void multiplePerTargetAspectsWithOrderAnnotation() {
157157
TestBean target = new TestBean();
158158
int realAge = 65;
159159
target.setAge(realAge);
@@ -283,7 +283,7 @@ private void namedPointcuts(Object aspectInstance) {
283283
int realAge = 65;
284284
target.setAge(realAge);
285285
ITestBean itb = createProxy(target, ITestBean.class,
286-
getAdvisorFactory().getAdvisors(aspectInstanceFactory(aspectInstance, "someBean")));
286+
getAdvisorFactory().getAdvisors(aspectInstanceFactory(aspectInstance, "someBean")));
287287
assertThat(itb.getAge()).as("Around advice must apply").isEqualTo(-1);
288288
assertThat(target.getAge()).isEqualTo(realAge);
289289
}
@@ -292,7 +292,7 @@ private void namedPointcuts(Object aspectInstance) {
292292
void bindingWithSingleArg() {
293293
TestBean target = new TestBean();
294294
ITestBean itb = createProxy(target, ITestBean.class,
295-
getAdvisorFactory().getAdvisors(aspectInstanceFactory(new BindingAspectWithSingleArg(), "someBean")));
295+
getAdvisorFactory().getAdvisors(aspectInstanceFactory(new BindingAspectWithSingleArg(), "someBean")));
296296
itb.setAge(10);
297297
assertThat(itb.getAge()).as("Around advice must apply").isEqualTo(20);
298298
assertThat(target.getAge()).isEqualTo(20);
@@ -483,7 +483,7 @@ void afterAdviceTypes() throws Exception {
483483
}
484484

485485
@Test
486-
void nonAbstractParentAspect() throws Exception {
486+
void nonAbstractParentAspect() {
487487
IncrementingAspect aspect = new IncrementingAspect();
488488

489489
// Precondition:
@@ -689,7 +689,7 @@ void doubleArg(ProceedingJoinPoint pjp, int x) throws Throwable {
689689
@Aspect
690690
static class Library {
691691

692-
@Pointcut("execution(!void get*())")
692+
@Pointcut("execution(int get*())") // before AspectJ 1.9.20, "!void" used to work instead of "int"
693693
void propertyAccess() {}
694694

695695
@Pointcut("execution(* *(..)) && args(i)")

0 commit comments

Comments
 (0)