Invert order of suppressed exceptions (for common exception rendering)

See gh-35057

Author: jhoeller

spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java

@@ -19,7 +19,6 @@
 import java.time.Duration;
 import java.util.ArrayDeque;
 import java.util.Deque;
-import java.util.Iterator;
 
 import org.jspecify.annotations.Nullable;
 
@@ -203,9 +202,7 @@ public void setRetryListener(RetryListener retryListener) {
 			RetryException finalException = new RetryException(
 					"Retry policy for operation '%s' exhausted; aborting execution".formatted(retryableName),
 					exceptions.removeLast());
-			for (Iterator<Throwable> it = exceptions.descendingIterator(); it.hasNext();) {
-				finalException.addSuppressed(it.next());
-			}
+			exceptions.forEach(finalException::addSuppressed);
 			this.retryListener.onRetryPolicyExhaustion(retryExecution, finalException);
 			throw finalException;
 		}

spring-core/src/test/java/org/springframework/core/retry/RetryTemplateTests.java

@@ -178,8 +178,8 @@ public String getName() {
 				.withMessage("Retry policy for operation 'test' exhausted; aborting execution")
 				.withCauseExactlyInstanceOf(IllegalStateException.class)
 				.satisfies(hasSuppressedExceptionsSatisfyingExactly(
-					suppressed1 -> assertThat(suppressed1).isExactlyInstanceOf(IOException.class),
-					suppressed2 -> assertThat(suppressed2).isExactlyInstanceOf(FileNotFoundException.class)
+						suppressed1 -> assertThat(suppressed1).isExactlyInstanceOf(FileNotFoundException.class),
+						suppressed2 -> assertThat(suppressed2).isExactlyInstanceOf(IOException.class)
 				));
 		// 3 = 1 initial invocation + 2 retry attempts
 		assertThat(invocationCount).hasValue(3);